Repository navigation
build(deps): bump the npm-security group across 1 directory with 6 updates - #217
Merged
Merged
Conversation
…dates Bumps the npm-security group with 6 updates in the / directory: | Package | From | To | | --- | --- | --- | | [happy-dom](https://github.com/capricorn86/happy-dom) | `20.14.6` | `21.0.4` | | [satori](https://github.com/vercel/satori) | `0.18.3` | `0.33.5` | | [sharp](https://github.com/lovell/sharp) | `0.34.5` | `0.35.5` | | [tmp](https://github.com/raszi/node-tmp) | `0.0.33` | `removed` | | [ws](https://github.com/websockets/ws) | `7.5.10` | `8.22.1` | | [uuid](https://github.com/uuidjs/uuid) | `8.3.2` | `14.0.3` | Updates `happy-dom` from 20.14.6 to 21.0.4 - [Release notes](https://github.com/capricorn86/happy-dom/releases) - [Commits](capricorn86/happy-dom@v20.14.6...v21.0.4) Updates `satori` from 0.18.3 to 0.33.5 - [Release notes](https://github.com/vercel/satori/releases) - [Commits](vercel/satori@0.18.3...0.33.5) Updates `sharp` from 0.34.5 to 0.35.5 - [Release notes](https://github.com/lovell/sharp/releases) - [Commits](lovell/sharp@v0.34.5...v0.35.5) Removes `tmp` Updates `ws` from 7.5.10 to 8.22.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.5.10...8.22.1) Updates `uuid` from 8.3.2 to 14.0.3 - [Release notes](https://github.com/uuidjs/uuid/releases) - [Changelog](https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md) - [Commits](uuidjs/uuid@v8.3.2...v14.0.3) --- updated-dependencies: - dependency-name: happy-dom dependency-version: 21.0.4 dependency-type: direct:development dependency-group: npm-security - dependency-name: satori dependency-version: 0.33.5 dependency-type: direct:development dependency-group: npm-security - dependency-name: sharp dependency-version: 0.35.5 dependency-type: direct:development dependency-group: npm-security - dependency-name: tmp dependency-version: dependency-type: indirect dependency-group: npm-security - dependency-name: ws dependency-version: 8.22.1 dependency-type: indirect dependency-group: npm-security - dependency-name: uuid dependency-version: 14.0.3 dependency-type: indirect dependency-group: npm-security ... Signed-off-by: dependabot[bot] <support@github.com>
This was referenced Nov 6, 2026
#217 Dependabot's lockfile for the security bumps failed `npm ci` under npm 11.6.2, the npm bundled with the Node 25.1.0 that CI reads from .nvmrc. npm reported the lockfile out of sync with package.json ("Missing: agent-base@9.0.0 from lock file" and the rest of the proxy-agent 9.x tree), so Format, Lint, Tests and Types all failed at install. npm 12 accepts the same file, which suggests Dependabot resolved it with a newer npm than CI runs. The lockfile is now regenerated from main's, with this PR's package.json, using npm 11.6.2 and --before=2026-11-03. The date cap keeps the newest adopted release at @lhci/cli 0.16.0 (2026-11-02), so nothing published in the last few days enters the tree: @sentry/node resolves to 11.10.0 rather than 11.11.0 and lighthouse's chrome-launcher to 1.2.2 rather than 1.2.3. Every security fix the PR targets is still in place. The cost is that @sentry/bundler-plugins 11.10.0 pulls glob 13.0.6 and minimatch 10.2.6, which carry moderate advisories. Both sit in the dev-only Lighthouse tree and never see untrusted patterns. npm ci (npm 11.6.2), tsc, vitest (875 tests), eslint and prettier all pass with the new lockfile.
ooloth
approved these changes
Nov 6, 2026
ooloth
left a comment
Owner
There was a problem hiding this comment.
Approving at 9e32f49. Dependabot's lockfile failed npm ci under the npm 11.6.2 that CI uses, so 9e32f49 regenerates it with that npm, capped at releases from before 2026-11-03.
The hand-started Check run passed Build, Metadata and Lighthouse at this head. The npm version mismatch is tracked in #218.
Owner
|
Verified in production: #217 is serving and every part of the claim holds. PR #217, merged as Rollout
Verdicts
Not observable here
|
ooloth
added a commit
to ooloth/dotfiles
that referenced
this pull request
Nov 6, 2026
The dependency bump check compared releases, the tree and advisories, but never tried to install the lockfile. On ooloth/michaeluloth.com#217 Dependabot wrote a lockfile that npm 12 accepts and npm 11.6.2, the npm CI gets from the repo's .nvmrc Node, rejects as out of sync. The script reported nothing about it; only reading CI's failed checks caught it. Each npm lockfile now gets an Install section. The script takes the npm version from package.json's packageManager, or else from the nearest .nvmrc or .node-version, mapping that Node version (exact, or a major or major.minor prefix that skips prereleases) to its bundled npm through nodejs.org's release index. It then runs `npm ci --dry-run --ignore-scripts` under that npm with `npm exec`, in the temp copy of the head that npm ls and npm audit already use, so nothing is installed and no package script runs. An EUSAGE rejection is flagged with npm's Missing/Invalid lines, and acceptance is reported with the npm version and where it came from. When the repo declares no version the script can resolve, such as an lts/* alias, that is flagged and the check runs with the local npm so a rejection still shows. A manifest with workspaces is flagged for a check by hand, since npm ci needs every member's package.json. Any other npm failure, or an unreachable or malformed index, exits 2. curl moves to the shared helpers section, since the npm side now uses it too. Run against #217 the check accepts the merged lockfile under npm 11.6.2 from .nvmrc, and it rejects Dependabot's original lockfile with "Missing: agent-base@9.0.0 from lock file" under the same npm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the npm-security group with 6 updates in the / directory:
20.14.621.0.40.18.30.33.50.34.50.35.50.0.33removed7.5.108.22.18.3.214.0.3Updates
happy-domfrom 20.14.6 to 21.0.4Release notes
Sourced from happy-dom's releases.
Commits
fd16352fix: Fixed a code injection vulnerability in the ESM compiler (#2537)75ab0fbfix: Fixed cross-origin isolation so opaque-origin data: iframes cannot acces...875ef5cfix: Fixes security vulnerability where authorization header was forwarded wh...1f3ffdffix: Fixes SSRF security vulnerability by doing a target-origin bypass in the...f55c7e0chore: Update security documentation (#2509)2b91e68fix: Adds alias for enabling CSS and iframe loading in server-renderer (#2503)0a99c75BREAKING CHANGE: Disables CSS and IFrame loading by default (#2502)Updates
satorifrom 0.18.3 to 0.33.5Release notes
Sourced from satori's releases.
... (truncated)
Commits
26a52affix: Harden SVG serialization (#814)499436fchore: Replace playground Monaco editor with sugar-high (#803)9668d20fix: Use Geist for playground cards (#790)6c400d5fix: Optimize opacity processing (#789)b22c04cfix: Better font caching (#788)ed7d78efix: Improve cache and update benchmark (~12% faster) (#787)b2127fefeat: Add HarfBuzz text shaping (#735)de6db71feat:backdrop-filter(#786)9487cbbfeat:shape()inclip-path(#785)8705f4cfeat:corner-shapesupport (#784)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for satori since your current version.
Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Updates
sharpfrom 0.34.5 to 0.35.5Release notes
Sourced from sharp's releases.
... (truncated)
Commits
51a990fRelease v0.35.596de105Upgrade to sharp-libvips v1.3.43a61390CI: Configure Dependabot with all package.json locations4940c50Improve gain map support for rotate/flip/flop ops20654aaPrerelease v0.35.5-rc.1ef4f934CI: Upgrade to Ubuntu 26.04358df95Upgrade to libvips v8.18.749f4903Improve gain map support for rotate-then-extract #46060e2e55eSilence a couple of compiler/static analysis warningscef3b8cImprove gain map support for extract operation #4606Removes
tmpUpdates
wsfrom 7.5.10 to 8.22.1Release notes
Sourced from ws's releases.
... (truncated)
Commits
c18a80a[dist] 8.22.12ab3d3e[minor] Usehttp.websocket{M,Unm}ask()if possible (#2347)c9efa88[ci] Test on node 27aa91518[test] Skip test on Node.js versions where it does not apply (#2340)b54ca10[fix] Do not truncate the URL path of IPC URLs at:(#2344)85319a7[minor] PreventSender.frame()from returning empty chunks297202c[dist] 8.22.08b918b0[feature] Introduce theprotocolsoption73e03eb[ci] Update actions/setup-node action to v7d9b8954[fix] Change the ready state after validating the arguments (#2337)Updates
uuidfrom 8.3.2 to 14.0.3Release notes
Sourced from uuid's releases.
... (truncated)
Changelog
Sourced from uuid's changelog.
... (truncated)
Commits
993ff7bchore(main): release 14.0.3 (#982)f7d19b9chore: update workflow actions (#983)b44f159fix: fix CITGM #1154 (#981)dd8c173chore: update deps (#975)fd59f02chore(main): release 14.0.2 (#967)f3c564edocs: point the Node support permalink at the CI version matrix (#974)b1da338fix(v1): set the multicast bit on v1Bytes's own randomly-generated node (#973)6adcc1dfix(v1): carry nsecs overflow into the timestamp's high bits (#972)ea83515docs: cleanup API summary (#968)ac36860chore: pinpublintversion in CI (#966)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for uuid since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.