Repository navigation
build(deps-dev): bump ws from 7.5.10 to 7.5.13 - #214
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [ws](https://github.com/websockets/ws) from 7.5.10 to 7.5.13. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.5.10...7.5.13) --- updated-dependencies: - dependency-name: ws dependency-version: 7.5.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Closed
10 tasks
ooloth
added a commit
that referenced
this pull request
Nov 6, 2026
…#215) ## ✅ What - Changes Dependabot so npm security fixes arrive in one grouped PR instead of one PR per package, and so major version upgrades are proposed as their own PRs instead of never - Minor and patch updates still arrive together in one monthly catch-all PR per ecosystem (npm and GitHub Actions), and releases still wait 7 days before Dependabot proposes them - The npm security group takes every kind of update, majors included, so a breaking fix sits in the same PR as the others rather than being split off. GitHub Actions gets no security group, because Dependabot creates no alerts for actions pinned to a SHA, so their fixes arrive as version updates - Packages that only work at matching versions arrive together, majors included: `next` with `eslint-config-next`, `react` with `react-dom` and their types, `tailwindcss` with `@tailwindcss/postcss`, `vitest` with `@vitest/ui`, and the `upload-artifact` and `download-artifact` actions - `@types/node` stops at major 25, the Node version in `.nvmrc`, so types never describe APIs the runtime doesn't have - npm can have up to 10 Dependabot PRs open at once and GitHub Actions up to 5, instead of 1 each, which leaves room for majors beside the groups - Starting the Check workflow by hand on any branch now runs Build, Metadata and Lighthouse there too, without deploying. That is how a Dependabot PR gets checked before it merges, and `CLAUDE.md` now says so - `npm run deploy:ci` now only looks for runs on `main` when it reports the run it started, so a check running on another branch can't be mistaken for the deploy ## 🤔 Why - 18 Dependabot PRs are open right now, one for each package with a security alert, because the existing group only covered regular version updates - Majors were ignored entirely, so packages like `@types/node` had fallen five majors behind with nothing proposing an upgrade - The security group can't be limited to minor and patch, because Dependabot judges a security update by the package's newest release rather than by the fix. `ws` 7.5.10 is fixed by a patch, but 8.x exists, so it would have been split off on its own - CI can't build Dependabot PRs on its own, because GitHub gives them none of the repo's Actions secrets, and the build fetches content with those secrets. A run you start yourself does get the secrets, so `CLAUDE.md` says to check each release for signs of a compromised publish first, then start that run, and merge only once it passes on the commit being merged - Dependabot only reads its config from `main`, so none of the new grouping shows until this merges ## 👩🔬 How to validate - [ ] `git fetch origin && git switch dependabot-security-groups` - [ ] `npx --yes js-yaml .github/dependabot.yml` - [ ] Expect the file to parse and print as JSON, with `artifacts` and `actions` under `github-actions`, and `next`, `react`, `tailwind`, `vitest`, `npm` and `npm-security` under `npm` - [ ] Expect only `actions` and `npm` to list `"update-types": ["minor", "patch"]`, and `npm-security` to have no `update-types` - [ ] Expect the `npm` entry to have `"open-pull-requests-limit": 10` and an `ignore` for `@types/node` versions `>=26` - [ ] `gh workflow run ci.yml -R ooloth/michaeluloth.com --ref dependabot-security-groups` - [ ] `gh run list -R ooloth/michaeluloth.com --workflow ci.yml --branch dependabot-security-groups --event workflow_dispatch --json databaseId,headSha,status --limit 1` - [ ] Expect a new run whose `headSha` is the branch's latest commit, then open it with `gh run view <databaseId> -R ooloth/michaeluloth.com` - [ ] Expect Build, Metadata and Lighthouse to run and pass, and Deploy and Notify to show as skipped - [ ] Open `CLAUDE.md` and expect the "Dependency Updates" section to say to check each release, then start that run, before merging a Dependabot PR ## 🔖 Related links - ooloth/dotfiles#251 - After this merges, Dependabot's first grouped security PR should replace the per-package ones (#190, #191, #193 to #198, #200 to #209, #213 and #214). Any it leaves open will be closed by hand
Contributor
Author
|
Superseded by #217. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps ws from 7.5.10 to 7.5.13.
Release notes
Sourced from ws's releases.
Commits
1680801[dist] 7.5.1318bcb11[fix] Reset the fragment counter when the message is complete98fce81[dist] 7.5.12deec211[fix] Lower default values ofmaxBufferedChunksandmaxFragmentsfb8a193[fix] Count empty fragments toward the limit (#2329)fd36cd8[dist] 7.5.11e14c458[security] Limit retained message partsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.