Repository navigation
test: handle host endianness in FileAPI Blob WPT tests - #66771
Closed
abhayagarwal-dev wants to merge 1 commit into
Closed
abhayagarwal-dev wants to merge 1 commit into
abhayagarwal-dev wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Member
|
Thank you for contributing this upstream. We'll run a WPT update worfklow for getting this updated in our repo instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66771 +/- ##
=======================================
Coverage 90.49% 90.50%
=======================================
Files 797 797
Lines 277598 277598
Branches 53336 53336
=======================================
+ Hits 251220 251245 +25
+ Misses 16790 16774 -16
+ Partials 9588 9579 -9 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ECMAScript TypedArrays store elements using host-native byte order. On big-endian architectures (such as IBM s390x / LinuxONE and AIX ppc64), TypedArray byte layouts differ from little-endian platforms, causing
Blob-constructor.any.jssubtests to fail when passing multi-byte TypedArrays (Uint16Array,Uint32Array,Float16Array,Float64Array,BigInt64Array).This PR:
Blob-constructor.any.jsWPT fixture with runtime host endianness detection (isLittleEndian) and adjusts the expected values so the subtests pass on both little-endian and big-endian systems.test/wpt/status/FileAPI/blob.cjsto remove the temporaryos.endianness() === 'BE'expected failure entries, as the tests now pass cleanly across all supported architectures.Test
Before (in Big-Endian machine):
After(In Big-Endian machine):
References
FileAPIwpt #55194