Skip to content

test: update WPT for FileAPI to 5878c7a7c0 - #66772

Closed
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/update-FileAPI-wpt
Closed

nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/update-FileAPI-wpt

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of the WPT for FileAPI to web-platform-tests/wpt@5878c7a.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Oct 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 15, 2026
@panva

panva commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

@abhayagarwal-dev you can push the status file change as a fixup to this PR's head. (Refs: #66771)

@abhayagarwal-dev

Copy link
Copy Markdown

@panva I don't have write access to push directly to nodejs/node.git actions/update-FileAPI-wpt (got a 403 error).

Here is the diff to remove the big-endian expected failures from test/wpt/status/FileAPI/blob.cjs now that they pass with the updated upstream WPT fixture:

diff --git a/test/wpt/status/FileAPI/blob.cjs b/test/wpt/status/FileAPI/blob.cjs
index c59516ca1dc..ff0f72445e9 100644
--- a/test/wpt/status/FileAPI/blob.cjs
+++ b/test/wpt/status/FileAPI/blob.cjs
@@ -23,17 +23,4 @@ module.exports = {
   'Blob-constructor-dom.window.js': {
     skip: 'Depends on DOM API',
   },
-  ...(os.endianness() === 'BE' ? {
-    'Blob-constructor.any.js': {
-      fail: {
-        note: 'The expected bytes assume a little-endian platform',
-        expected: [
-          'Passing typed arrays as elements of the blobParts array should work.',
-          'Passing a Float16Array as element of the blobParts array should work.',
-          'Passing a Float64Array as element of the blobParts array should work.',
-          'Passing BigInt typed arrays as elements of the blobParts array should work.',
-        ],
-      },
-    },
-  } : {}),
 };

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@panva panva removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 15, 2026
@panva
panva marked this pull request as draft October 15, 2026 17:18
@panva

panva commented Oct 15, 2026

Copy link
Copy Markdown
Member

Need to deal with the underlying issue related to incorrect handling of detached buffers first.

@abhayagarwal-dev

Copy link
Copy Markdown

Should i open another PR in this repo and refer it here once open?

@panva

panva commented Oct 15, 2026

Copy link
Copy Markdown
Member

Should i open another PR in this repo and refer it here once open?

I'm on it. There's more to it than just detached handling as far as i can see.

@panva panva closed this Oct 15, 2026
@panva
panva deleted the actions/update-FileAPI-wpt branch October 15, 2026 18:13
@panva

panva commented Oct 15, 2026

Copy link
Copy Markdown
Member

Fixes and wpt bump in #66776

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (1c90519) to head (ad0ec28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66772      +/-   ##
==========================================
- Coverage   90.49%   90.49%   -0.01%     
==========================================
  Files         797      797              
  Lines      277598   277598              
  Branches    53336    53341       +5     
==========================================
- Hits       251220   251213       -7     
+ Misses      16790    16784       -6     
- Partials     9588     9601      +13     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants