Skip to content

fix(land): the fixer runs a repository's checks with their own services and dev shell #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 1 commit into from
Nov 9, 2026
Merged

fix(land): the fixer runs a repository's checks with their own services and dev shell #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions assets/land-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,12 @@ behavior changes or review must be handed back.
Build tools may fetch the dependencies the repository's manifests and lockfiles
name: from their package registries, such as crates.io, npm, PyPI, and the Go
module proxy, and from `github.com` and `codeload.github.com` for git
dependencies. Do not build with `--offline` to avoid them. These fetches are the
only GitHub contact allowed: never call GitHub's API yourself (`gh`,
`api.github.com`), push, or reach any other host.
dependencies. Do not build with `--offline` to avoid them. The repository's
checks may also reach the services their own tests use, such as a payment
provider's test mode or a media download: run them as they are, and never stop
them or hand a PR back for it. Dependency fetches are your only GitHub contact:
never call GitHub's API yourself (`gh`, `api.github.com`), push, or reach any
other host.

Write `quest-land-result.json` in the repository root: a JSON array with exactly
one entry per supplied PR, no extra fields. Use one of:
Expand Down Expand Up @@ -85,7 +88,9 @@ and `just test`: this prompt asks you to run them, so they are no standing guida
to ignore, and a PR's diff never names them for you. Where the base names none, run
each touched language's own type check and linter beside its build and test. A
`requeue` of an unchanged head runs the same checks on a scratch merge kept off its
branch, since the base may have moved under it. Name each command you ran in the
branch, since the base may have moved under it. Run them in the repository's dev
shell, if it has one, entered from the tree they check rather than from `base`,
since a merge can change the shell's inputs. Name each command you ran in the
reason. A PR you cannot get passing mechanically, or whose checks you cannot run,
goes back as a handback quoting the command and the output line that shows why in
the diagnosis.
Expand Down
3 changes: 3 additions & 0 deletions test/land.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3533,6 +3533,9 @@ ${requeueScript}`);
"Do not build with `--offline`",
"never call GitHub's API yourself",
"or reach any other host",
"checks may also reach the services their own tests use",
"never stop them or hand a PR back for it",
"entered from the tree they check rather than from `base`",
"Before reporting `fixed` or `requeue`, run the repository's own checks on the head you report merged with `base`",
"lint, format, and type checks as well as build and test",
"Take the commands from the base's root instructions",
Expand Down