Repository navigation
fix(land): the fixer runs a repository's checks with their own services and dev shell - #593
Conversation
…es and dev shell Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: cbf1d07.
No concrete bugs found in the two-file diff. The direction fits the reported failures: permit the repository's own test-service traffic and enter the dev shell from the merged tree, while retaining the fixer's restrictions on direct GitHub calls and pushes.
Verification limits: static inspection of the full fixer prompt and the affected test. The added assertions pin wording, not actual network or dev-shell behavior. I did not run builds or tests; the exact-head GitHub Check and Queue workflow runs inspected were skipped.
(written by unknown)

The land fixer could not requeue a moq.pro PR that a flaky test ejected. Two rules in
assets/land-fix.mdcollided: arequeuemust first pass the repository'sjust checkandjust teston a scratch merge, and the fixer may reach no host beyond package registries and GitHub. moq.pro'sjust testdownloads clips fromvid.moq.devand drives Stripe's test mode (api.stripe.com). On 2026-11-09, every flake ejection in moq.pro's queue (moq-dev/moq.pro#3771, #3765, #3763, #3757, #3756, #3714) came back as a handback. In the fixer logs, Codex re-ran the flaky test, saw it pass, startedjust test, and then stopped itself before the suite reached those hosts. The container's network was open; the prompt was the block.The 3771/3765 round also ran the gates in
nix develop /work(the base checkout's shell) against a scratch merge that changedflake.lock, and moq.pro's devshell guard refused with "the active shell was built from a different flake.lock".Consumer: quest land's fixer on every repository whose checks use outside services or a dev shell, moq.pro first.
Changes
assets/land-fix.md: the repository's checks may reach the services their own tests use; the fixer runs them as they are and never stops them or hands a PR back for it. The host rule still bars the fixer's own requests: no GitHub API, no push, no other host.assets/land-fix.md: the checks run in the repository's dev shell, entered from the tree they check rather than frombase.test/land.test.ts: the existing prompt test pins both.Public API and wire impact
None. The fixer prompt changes; no CLI, result format, or daemon behavior does.
Caused by
Validation
nix develop -c just check: pass.quest gate nix develop -c just test: pass.Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with high)
Review
Rewritten by
quest reviewafter each round.01a1c29a-cfdb-7242-968e-118e079d13b1, round 1Code inspection found no actionable regressions, but runtime validation remains unverified because no builds or tests were run.