Skip to content

fix(land): the fixer runs a repository's checks with their own services and dev shell - #593

Merged
kixelated merged 1 commit into
mainfrom
fix/land-fixer-check-network
Nov 9, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/land-fixer-check-network

Conversation

@kixelated

@kixelated kixelated commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

The land fixer could not requeue a moq.pro PR that a flaky test ejected. Two rules in assets/land-fix.md collided: a requeue must first pass the repository's just check and just test on a scratch merge, and the fixer may reach no host beyond package registries and GitHub. moq.pro's just test downloads clips from vid.moq.dev and drives Stripe's test mode (api.stripe.com). On 2026-11-09, every flake ejection in moq.pro's queue (moq-dev/moq.pro#3771, #3765, #3763, #3757, #3756, #3714) came back as a handback. In the fixer logs, Codex re-ran the flaky test, saw it pass, started just test, and then stopped itself before the suite reached those hosts. The container's network was open; the prompt was the block.

The 3771/3765 round also ran the gates in nix develop /work (the base checkout's shell) against a scratch merge that changed flake.lock, and moq.pro's devshell guard refused with "the active shell was built from a different flake.lock".

Consumer: quest land's fixer on every repository whose checks use outside services or a dev shell, moq.pro first.

Changes

  • assets/land-fix.md: the repository's checks may reach the services their own tests use; the fixer runs them as they are and never stops them or hands a PR back for it. The host rule still bars the fixer's own requests: no GitHub API, no push, no other host.
  • assets/land-fix.md: the checks run in the repository's dev shell, entered from the tree they check rather than from base.
  • test/land.test.ts: the existing prompt test pins both.

Public API and wire impact

None. The fixer prompt changes; no CLI, result format, or daemon behavior does.

Caused by

  • moq-dev/quest#356 - required full checks before a requeue while allowing only dependency hosts, which a repository whose tests use outside services cannot satisfy.

Validation

  • nix develop -c just check: pass.
  • quest gate nix develop -c just test: pass.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with high)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, low effort
  • Session: 01a1c29a-cfdb-7242-968e-118e079d13b1, round 1
  • Head: cbf1d07
  • Base: origin/main at 91cd1d3
  • Score: 9/10, Code inspection found no actionable regressions, but runtime validation remains unverified because no builds or tests were run.
  • Findings: none

…es and dev shell

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 9, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

@kixelated
kixelated marked this pull request as ready for review November 9, 2026 23:18
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 54c93d81-a24c-422d-9b9b-6dd6530065e8
Commits

Reviewing files that changed from the base of the PR and between 91cd1d3 and cbf1d07.

Files selected for processing: 2

  • assets/land-fix.md
  • test/land.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: cbf1d07.

No concrete bugs found in the two-file diff. The direction fits the reported failures: permit the repository's own test-service traffic and enter the dev shell from the merged tree, while retaining the fixer's restrictions on direct GitHub calls and pushes.

Verification limits: static inspection of the full fixer prompt and the affected test. The added assertions pin wording, not actual network or dev-shell behavior. I did not run builds or tests; the exact-head GitHub Check and Queue workflow runs inspected were skipped.

(written by unknown)

@kixelated
kixelated added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 1e11178 Nov 9, 2026
11 checks passed
@kixelated
kixelated deleted the fix/land-fixer-check-network branch November 9, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant