Skip to content

quest: drop relay-peer-addr, shipped as ConnectInfo in #6430 - #7353

Merged
moq-bot[bot] merged 3 commits into
mainfrom
quest/m2/relay-peer-addr
Oct 31, 2026
Merged

moq-bot[bot] merged 3 commits into
mainfrom
quest/m2/relay-peer-addr

Conversation

@kixelated

@kixelated kixelated commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Deletes quest/m2/relay-peer-addr.md and its link from the m2 README. The work it asks for already shipped.

The quest (planned in moq-dev/moq#5877, 2026-10-17) asked that embedded relay routes, WHIP/WHEP included, read the verified client socket address rather than a forwarded header. Six days later moq-dev/moq#6430 (a604a0bf1b) did that:

  • Web::serve builds its service with into_make_service_with_connect_info::<SocketAddr>() (rs/moq-relay/src/web.rs:448). Any route an embedder merges in, such as moq_rtc::Server::publish_router / subscribe_router, or a middleware wrapping them, can extract ConnectInfo<SocketAddr>.
  • A regression test (rs/moq-relay/src/web.rs, the /remote embedded-route test) sends a forged X-Forwarded-For and asserts the extracted value is the TCP peer.
  • doc/bin/relay/index.md documents it for embedders.
  • Native QUIC already has remote_addr().

That PR also settled the Plan's open API question. It chose axum's standard ConnectInfo over the MtlsPeer-style extension the Plan recommended: "Publishing the listener wrapper or adding another peer extension would expose an extra type for information Axum already represents." It is newer than the quest's recommendation, so this follows it.

Decisions

  1. ✅ Delete this quest (maintainer, 2026-10-30): it shipped as ConnectInfo in moq-dev/moq#6430. The rewrite option (a moq_rtc::Session accessor for the ICE-selected address) was not picked.

Choices made without asking

Review

Skipped: the diff only deletes a quest file and one link line, with no code change. quest check --base origin/main passes on e091eaa.

Follow-ups

  • None.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 30, 2026 04:59
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Relay exposes a verified peer address quest: drop relay-peer-addr, shipped as ConnectInfo in #6430 Oct 30, 2026
@kixelated
kixelated marked this pull request as ready for review October 30, 2026 20:12
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 933bbd1b-5837-45a4-b8ff-7e41ce0c7315
Commits

Reviewing files that changed from the base of the PR and between 9387174 and e091eaa.

Files selected for processing: 2
  • quest/m2/README.md
  • quest/m2/relay-peer-addr.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T20:13:17.340719Z e091eaa Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated enabled auto-merge (squash) October 30, 2026 20:12

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: e091eaa

No actionable bugs found in this two-file documentation deletion. Removing the completed quest and its index entry is a sensible direction: the existing Web::serve supplies ConnectInfo<SocketAddr>, the embedder documentation explains its accepted-socket semantics, and the existing regression test checks a forged forwarding header. Reusing axum's extractor avoids an unnecessary second peer-address API.

Verification: static inspection of the diff, relevant implementation, documentation, and test source only; no tests or builds were run.

@moq-bot
moq-bot Bot disabled auto-merge October 31, 2026 03:04
@moq-bot moq-bot Bot removed the quest:merge label Oct 31, 2026
@moq-bot

moq-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

quest land removed this pull request from the queue: GitHub refused /repos/moq-dev/moq/pulls/7407: Pull Request has merge conflicts; the rest of the batch was not merged.

@moq-bot

moq-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Codex land fixer: fixer disappeared before recording an exit status; run /quest-iterate. Recommendation: run /quest-iterate before picking it again.

(written by Codex)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Re-landing after the head_moved stop on 2026-10-31T03:04:50Z.

  • The head did not change: it is still e091eaa (pushed 2026-10-30T12:00:25Z). The stop came from batch PR quest: /fetch answers from the announce sync instead of waiting #7407 hitting a merge conflict, and the maintainer says the land queue is now fixed.
  • The ## Review record (a skip, since the diff only deletes a quest file and one link) names this head, and an OpenAI review of the same head found nothing actionable.
  • quest check --base origin/main --branch quest/m2/relay-peer-addr passes on this head against main at 1d8bf24 (665 documents ok). GitHub reports the PR as mergeable, with 19/19 checks passing.

Nothing was changed on the branch. Queueing e091eaa again with --squash.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 31, 2026 03:53
@moq-bot
moq-bot Bot merged commit 418ce82 into main Oct 31, 2026
7 checks passed
@moq-bot
moq-bot Bot deleted the quest/m2/relay-peer-addr branch October 31, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant