Repository navigation
quest: drop relay-peer-addr, shipped as ConnectInfo in #6430 - #7353
Conversation
Quest-Claim: cad4f7f171dee46c
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: e091eaa
No actionable bugs found in this two-file documentation deletion. Removing the completed quest and its index entry is a sensible direction: the existing Web::serve supplies ConnectInfo<SocketAddr>, the embedder documentation explains its accepted-socket semantics, and the existing regression test checks a forged forwarding header. Reusing axum's extractor avoids an unnecessary second peer-address API.
Verification: static inspection of the diff, relevant implementation, documentation, and test source only; no tests or builds were run.
|
quest land removed this pull request from the queue: GitHub refused /repos/moq-dev/moq/pulls/7407: Pull Request has merge conflicts; the rest of the batch was not merged. |
|
Codex land fixer: (written by Codex) |
|
Re-landing after the
Nothing was changed on the branch. Queueing e091eaa again with (Written by Claude Opus 5.5) |
Summary
Deletes
quest/m2/relay-peer-addr.mdand its link from the m2 README. The work it asks for already shipped.The quest (planned in moq-dev/moq#5877, 2026-10-17) asked that embedded relay routes, WHIP/WHEP included, read the verified client socket address rather than a forwarded header. Six days later moq-dev/moq#6430 (a604a0bf1b) did that:
Web::servebuilds its service withinto_make_service_with_connect_info::<SocketAddr>()(rs/moq-relay/src/web.rs:448). Any route an embedder merges in, such asmoq_rtc::Server::publish_router/subscribe_router, or a middleware wrapping them, can extractConnectInfo<SocketAddr>.rs/moq-relay/src/web.rs, the/remoteembedded-route test) sends a forgedX-Forwarded-Forand asserts the extracted value is the TCP peer.doc/bin/relay/index.mddocuments it for embedders.remote_addr().That PR also settled the Plan's open API question. It chose axum's standard
ConnectInfoover theMtlsPeer-style extension the Plan recommended: "Publishing the listener wrapper or adding another peer extension would expose an extra type for information Axum already represents." It is newer than the quest's recommendation, so this follows it.Decisions
ConnectInfoin moq-dev/moq#6430. The rewrite option (amoq_rtc::Sessionaccessor for the ICE-selected address) was not picked.Choices made without asking
ConnectInfo.Review
Skipped: the diff only deletes a quest file and one link line, with no code change.
quest check --base origin/mainpasses on e091eaa.Follow-ups
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)