Repository navigation
quest: delete group-failed, which has no named consumer - #7496
Conversation
Quest-Claim: 6cef22d4ca0c7195
The quest's Plan makes a named consumer the precondition and says to propose deletion if none exists when work starts. None does in the tree: no encoder, stats counter, or binding reads a failed-group signal, and the one use case on record (a lossless publisher re-sending a reset group, from #6059) predates the budget rule under which a reset group is one the subscriber has already moved past. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
kixelated
changed the title
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 8b93f1c9ecb5e19cd3c89bdaaa1872f9b5946b22.
No actionable bugs found. Removing the unimplemented failed-group quest and its index entry is a proportionate simplification, consistent with the plan's explicit delete-if-no-consumer condition. This drops speculative notification/API work without changing runtime behavior, public API, or wire format. The repository search returned only the index reference, which this diff removes.
No prior published review findings to carry forward. Verification was static GitHub inspection of the two-file change, surrounding quest index, instructions, history, and references; I did not run quest check or tests.
(Written by OpenAI)
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
group-failedquest deleted — removesquest/m2/group-failed.mdand its single index entry inquest/m2/README.md. No code, public API, or wire change.- Deletion is complete — repo-wide search for
group-failed,group_failed, and the quest title returns no dangling references, andquest/README.mdindexes milestones rather than individual quests, so no other index needs updating. - Decision recorded — the PR body carries the maintainer's 2026-11-01 decision and the consumer search that the quest's own Plan required, matching the pattern of prior quest deletions (#7416, #7353).
deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏
Deletes
quest/m2/group-failed.mdwithquest rm. This removes the file and its entry in the m2 README. The maintainer chose deletion on 2026-11-01 (see Decisions).Why
The quest's Plan, decided on 2026-10-20, makes a named consumer the first step: "Name the consumer first, such as an encoder that forces a keyframe or a stats counter ... If none exists by the time this starts, propose deleting the quest." I looked for one and found none:
rs/moq-video(encode::Control),rs/moq-boy(force_keyframe), andjs/publish(cut) are driven by group demand, joins, and resumes. Nothing reads a delivery failure. In moq every group starts with a keyframe, so a subscriber that loses a group recovers at the next group with no forced keyframe.stats::Renditionandecho::Rendition(media stats) have no failed-group counter, and no planned stats quest asks for one.Track.Producer.failedwas first proposed so that a lossless publisher could write a reset group's content again as a new group. The same PR then dropped it, with this reasoning: "under the budget rule a reset group is one the subscriber has already moved past". For a reliable group the subscriber still needs, recovery from the subscriber side (fetching a dropped group, or refilling an evicted one) avoids racing a re-send against the reset.No code changes. Public API: none. Wire: none.
Decisions
/quest-planscopes a new quest around what that consumer needs. Keeping the quest with a named consumer, or turning it into a waiting quest, was not chosen.Checks
bf4e726f66.quest/m2/README.mdauto-merged with no conflicts.quest check --base origin/mainon8b93f1c9ec: 639 documents ok.Review
Skipped under the simple-review rule (quest guide, moq-dev/quest#364): the PR only deletes a quest through
quest rmand carries no behavior risk, so it relies on the online reviewers. Head8b93f1c9ec. The earlier head had no online-reviewer threads.Follow-ups
None.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)