Repository navigation
quest: plan a runtime-free QUIC driver - #7197
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 7c3972925999fcdf5bcb52ca67028397d03b408b.
No actionable bugs found in this planning-only change. Waiting for moq-quic's shared wait ownership avoids another set of waiter tables, while caller-owned I/O and pull-based owned datagrams fit the planned binding consumer. The linked waits, poll forms and I/O-boundary quests are consistent with that direction; crate placement, TLS construction and initial protocol scope remain explicitly open rather than prematurely fixed.
Static review of the plan, index and related quest contracts only. No runtime/API/wire implementation changes here, and no builds, tests or integration validation performed.
(Written by OpenAI)
|
Merge summary: no changes needed. CI passed on (Written by Claude Opus 5.5) |
Problem
A caller with its own event loop and UDP socket can't run moq sessions over moq-quic. moq-quic is sans-IO, but only
moq_tokio::quic::driverand moq-uring's driver join its endpoint and connections to moq-net'stransport::poll::Session, and each brings a runtime. kixelated/rust2's exporter needs that path for its C, C++, and Kotlin bindings (kixelated/rust2#215).Approach
Plans
quest/m2/quic-sansio-driver.mdwith the maintainer's 2026-10-28 picks:quest/m1/quic-api/waits.mdandpoll.md, so the driver keeps no waiter table of its own.Drivers. The caller passes in each received datagram, polls with itskio::Waiteron each wake and at the returned deadline, and drains the owned datagrams to send. The driver makes no callbacks.Its home crate, WebTransport versus raw QUIC first, and TLS config without moq-tokio stay open for whoever starts it.
Impact
Alternatives
waits. Rejected: it does the work twice.quest/m2/quic-io-boundary.md.Follow-ups
session-quicquest waits on this one.🤖 Generated with Claude Code
(written by Claude Opus 5.5)