Skip to content

quest: plan a runtime-free QUIC driver - #7197

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/quic-sansio-driver
Oct 29, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/quic-sansio-driver

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

A caller with its own event loop and UDP socket can't run moq sessions over moq-quic. moq-quic is sans-IO, but only moq_tokio::quic::driver and moq-uring's driver join its endpoint and connections to moq-net's transport::poll::Session, and each brings a runtime. kixelated/rust2's exporter needs that path for its C, C++, and Kotlin bindings (kixelated/rust2#215).

Approach

Plans quest/m2/quic-sansio-driver.md with the maintainer's 2026-10-28 picks:

  • It waits on quest/m1/quic-api/waits.md and poll.md, so the driver keeps no waiter table of its own.
  • Datagrams move by pull, like moq-net's Drivers. The caller passes in each received datagram, polls with its kio::Waiter on each wake and at the returned deadline, and drains the owned datagrams to send. The driver makes no callbacks.

Its home crate, WebTransport versus raw QUIC first, and TLS config without moq-tokio stay open for whoever starts it.

Impact

  • None. This only adds a quest.

Alternatives

  • Build the adapter now with its own waiter tables, then rework it after waits. Rejected: it does the work twice.
  • Push datagrams through a send callback the caller supplies, or transmit into a buffer the caller lends. Rejected for now: bindings can't take either across a C ABI yet. A lent buffer can follow on quest/m2/quic-io-boundary.md.

Follow-ups

  • kixelated/rust2's session-quic quest waits on this one.

🤖 Generated with Claude Code

(written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 05a47b21-d6f7-46cf-b59f-9f6726862f31
Commits

Reviewing files that changed from the base of the PR and between edce00d and 7c39729.

Files selected for processing: 2
  • quest/m2/README.md
  • quest/m2/quic-sansio-driver.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T04:50:25.307980Z 7c39729 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 7c3972925999fcdf5bcb52ca67028397d03b408b.

No actionable bugs found in this planning-only change. Waiting for moq-quic's shared wait ownership avoids another set of waiter tables, while caller-owned I/O and pull-based owned datagrams fit the planned binding consumer. The linked waits, poll forms and I/O-boundary quests are consistent with that direction; crate placement, TLS construction and initial protocol scope remain explicitly open rather than prematurely fixed.

Static review of the plan, index and related quest contracts only. No runtime/API/wire implementation changes here, and no builds, tests or integration validation performed.

(Written by OpenAI)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: no changes needed. CI passed on 7c3972925999fcdf5bcb52ca67028397d03b408b. Codex reacted with no findings, and the automated review of this head found nothing actionable. quest check --base origin/main passes. The plan's open questions (which crate it lives in, WebTransport or raw QUIC first, TLS config without moq-tokio) stay with whoever starts the quest, as the PR body says. Queued in the merge queue.

(Written by Claude Opus 5.5)

Merged via the queue into main with commit e86d5c5 Oct 29, 2026
10 checks passed
@kixelated
kixelated deleted the quest-plan/quic-sansio-driver branch October 29, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant