Skip to content

chore(quest): session-quic waits on moq's runtime-free QUIC driver - #215

Merged
kixelated merged 3 commits into
mainfrom
quest/m1/ffi-export/session-quic
Oct 29, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m1/ffi-export/session-quic

Conversation

@kixelated

@kixelated kixelated commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

quest/m1/ffi-export/session-quic.md can't start. At the pinned moq (30f25c04), only moq-tokio's and moq-uring's drivers join moq-quic to moq-net's transport::poll::Session, and each brings a runtime. The runtime-free driver a binding needs is moq's change, not the exporter's.

Approach

Plan only, with no source changes. The maintainer picked these on 2026-10-28:

  • moq plans a runtime-free QUIC driver in moq-dev/moq#7197. It is blocked on moq-quic owning its waits and on the drivers' poll forms (moq's quest/m1/quic-api/waits.md and poll.md).
  • Datagrams move by pull, like the origin's Driver. The binding passes in each received datagram, polls on each wake and at the returned deadline, and drains the owned datagrams to send. No callback crosses the ABI, and no buffer is lent mutably.

session-quic.md now waits on that quest inline, as crates.md waits on moq's kio::clock. It records moq-quic's census at the pin: 60% of types, 86% of methods, and 0 of 9 traits export. The epic README's line says it waits on the driver.

Impact

  • None. This changes quests only.

Alternatives

  • Build the adapter in moq now with its own waiter tables. Rejected: it would be redone after moq's waits.
  • Push datagrams through a send callback, or transmit into a lent buffer. The exporter refuses callback signatures and &mut [u8] today. A lent buffer can follow later as an optimization.

Follow-ups

  • When moq's driver lands, bump the moq pin and export it. That is the remaining work in session-quic.md.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Sessions on sans-IO QUIC chore(quest): session-quic waits on moq's runtime-free QUIC driver Oct 29, 2026
@kixelated
kixelated marked this pull request as ready for review October 29, 2026 04:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T13:42:21.394916Z 05dbb5d New commits
🔒 Security Review ✅ Completed 2026-10-29T13:43:01.245780Z 05dbb5d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 0c11379da27d76c7b243008dcb9e439ab03dde8e.

No actionable bugs found in this planning-only change. Keeping the runtime-free transport adapter in moq, then updating the pin and exporting its public API, avoids a duplicate binding-specific driver. The pull/owned-datagram contract and wait dependency agree with the plan in moq-dev/moq#7197, while the existing local-server proof remains the completion goal.

Static review of the quest and dependency contract only. No source/API/wire behavior changes here. I did not run builds, tests or the census, and have not independently reproduced its coverage percentages.

(Written by OpenAI)

@kixelated
kixelated merged commit a2df378 into main Oct 29, 2026
1 check passed
@kixelated
kixelated deleted the quest/m1/ffi-export/session-quic branch October 29, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant