Repository navigation
chore(quest): session-quic waits on moq's runtime-free QUIC driver - #215
Conversation
Quest-Claim: 24102ac48aab8621
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 0c11379da27d76c7b243008dcb9e439ab03dde8e.
No actionable bugs found in this planning-only change. Keeping the runtime-free transport adapter in moq, then updating the pin and exporting its public API, avoids a duplicate binding-specific driver. The pull/owned-datagram contract and wait dependency agree with the plan in moq-dev/moq#7197, while the existing local-server proof remains the completion goal.
Static review of the quest and dependency contract only. No source/API/wire behavior changes here. I did not run builds, tests or the census, and have not independently reproduced its coverage percentages.
(Written by OpenAI)
Problem
quest/m1/ffi-export/session-quic.md can't start. At the pinned moq (
30f25c04), only moq-tokio's and moq-uring's drivers join moq-quic to moq-net'stransport::poll::Session, and each brings a runtime. The runtime-free driver a binding needs is moq's change, not the exporter's.Approach
Plan only, with no source changes. The maintainer picked these on 2026-10-28:
quest/m1/quic-api/waits.mdandpoll.md).Driver. The binding passes in each received datagram, polls on each wake and at the returned deadline, and drains the owned datagrams to send. No callback crosses the ABI, and no buffer is lent mutably.session-quic.mdnow waits on that quest inline, ascrates.mdwaits on moq'skio::clock. It records moq-quic's census at the pin: 60% of types, 86% of methods, and 0 of 9 traits export. The epic README's line says it waits on the driver.Impact
Alternatives
waits.&mut [u8]today. A lent buffer can follow later as an optimization.Follow-ups
session-quic.md.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)