Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quest/m1/interop-coverage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ coverage on `main` at `3ab6cbf81d`.
## Required

- [JS namespace lifecycle](/quest/m1/interop-coverage/js-namespace-done.md) - the runner's moq-dev-js client moves to an `@moq/net` that withdraws namespaces by reset, so subscribe-namespace-lifecycle passes on Cloudflare draft-18 and aiomoqt
- [JS subgroup data through imquic](/quest/m1/interop-coverage/js-imquic-objects.md) - moq-dev-js data-subgroup-basic passes against imquic, or the cell is classified with imquic's split-header bug reported upstream
- [JS subgroup data through imquic](/quest/m1/interop-coverage/js-imquic-objects.md) - the runner's moq-dev-js client moves to an `@moq/net` patch that writes data stream headers in one write, so data-subgroup-basic passes against imquic
- [Late join and FETCH](/quest/m1/interop-coverage/late-join.md) - a late subscriber gets the current group from object 0, and a standalone FETCH returns a past group exactly

## Related
Expand Down
68 changes: 33 additions & 35 deletions quest/m1/interop-coverage/js-imquic-objects.md
Original file line number Diff line number Diff line change
@@ -1,42 +1,40 @@
# [XS] JS subgroup data reaches the subscriber through imquic
# [XS] The runner's JS client writes data stream headers in one write

## Goal

The runner's moq-dev-js `data-subgroup-basic` case passes against imquic
(draft-22, WebTransport), or the cell is classified with the imquic issue
reported upstream. Check the cell on the runner's report.
Condition: the next `@moq/net` patch release, 0.4.7 or later, ships from
`release` carrying [moq-dev/moq#6769](https://github.com/moq-dev/moq/pull/6769),
the JS-only `release` backport of
[moq-dev/moq#6504](https://github.com/moq-dev/moq/pull/6504). Check that
`npm view @moq/net version` is above 0.4.6 and that
`git log origin/release -- js/net/package.json` shows a bump after the
backport merged. Releases are cut separately; this quest bumps nothing.

Then bump `@moq/net` in the moq-dev-js client of
[englishm/moq-interop-runner](https://github.com/englishm/moq-interop-runner)
to it, so `data-subgroup-basic` passes against imquic (draft-22,
WebTransport), and delete this quest once that PR merges. If imquic fixes
[meetecho/imquic#43](https://github.com/meetecho/imquic/issues/43) first and
the runner rebuilds its image, the cell turns green without the bump; delete
the quest then.

## Plan

imquic drops a SUBGROUP_HEADER (or FETCH_HEADER) that arrives across more
than one stream read: `imquic_moq_parse_message` creates the data stream on
the first chunk but only buffers bytes once the header has parsed, so the
rest of the header and every object are discarded, and the relay logs
imquic drops a SUBGROUP_HEADER or FETCH_HEADER that arrives across more
than one stream read, so the relay discards every object and logs
`No track found for that subscription` with alias 0 at the stream's FIN.
QUIC may split a stream anywhere, so this is imquic's bug, reported as
[meetecho/imquic#43](https://github.com/meetecho/imquic/issues/43).
`@moq/net` 0.4.4 wrote the header one field per write, which the polyfill
sent as separate frames; moq-dev-rs buffers it and passes.

[moq-dev/moq#6504](https://github.com/moq-dev/moq/pull/6504) writes both
data stream headers in one write. The maintainer kept it on 2026-10-23
even though the root cause is imquic's: it matches the Rust publisher and
the one-write control messages from
[moq-dev/moq#6255](https://github.com/moq-dev/moq/pull/6255), and also
covers FETCH_HEADER. Reproduced and verified against the runner's imquic
relay image and `lminiero.it:9000`: 0.4.4 fails every run, and passes once
patched.

Remaining:

- The cell turns green once imquic buffers a split header, or once the
runner's JS client moves to a `@moq/net` release with
[moq-dev/moq#6504](https://github.com/moq-dev/moq/pull/6504). Delete
this quest then.
- On `main`, `request(path, { announced: true })` asks SUBSCRIBE_NAMESPACE
for the tuple's own namespace, and imquic never answers with the shorter
routing prefix the publisher announced, so the subscriber never
subscribes. 0.4.4 asked for the prefix. The runner's client hits this
when it moves past 0.4.4 unless it requests blindly.

Public API: none. Wire: none (bytes unchanged, fewer writes).
`@moq/net` 0.4.6 and earlier write the header one field per write, which
the polyfill sends as separate frames. `main` writes it in one write since
#6504, and the backport does the same on `release`. Against the runner's
imquic relay image, the runner's client fails every run on 0.4.4 and passes
3/3 on the backport branch.

The runner's client must stay on the 0.4 line for this: `main`'s announced
request watches the tuple's exact path, which moq-transport relays answer
only with namespaces beneath it, so it never discovers the shorter routing
prefix the publisher claimed. That is recorded on
[Runner client bump](/quest/m2/release/runner-client-bump.md), which moves
the client to `main`'s cut.

The interop audit's standing approval covers PRs touching the `moq-dev-*`
builds.
8 changes: 7 additions & 1 deletion quest/m2/release/runner-client-bump.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,10 @@ subscription under `data-subgroup-basic`'s dynamic claim then fails
[announce takeover](/quest/m1/announce-takeover.md) removes, so check
whether that has landed before calling it a client bug. The JS client's
announcement check also moves from `"retracted"` to `"end"` when it takes
the cut.
the cut. Its `data-subgroup-basic` subscriber also stalls there: on `main`,
`request(path, { announced: true })` asks SUBSCRIBE_NAMESPACE for the
tuple's own namespace, and a moq-transport relay such as imquic answers only
with namespaces beneath it, never the shorter routing prefix the publisher
claimed. 0.4.x asked for the origin's scoped prefix. Untested options: hold
an `announced(Path.Pattern.subtree(prefix))` stream while requesting, or
request blindly.
Loading