Skip to content

chore(quest): wait on the release backport of the one-write data stream header - #6764

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/interop-coverage/js-imquic-objects
Oct 25, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/interop-coverage/js-imquic-objects

Conversation

@kixelated

@kixelated kixelated commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Works on quest/m1/interop-coverage/js-imquic-objects.md.

Summary

The runner's moq-dev-js data-subgroup-basic still fails against imquic because the client pins @moq/net 0.4.4, and no release carries moq-dev/moq#6504: it merged on main after 0.4.6 shipped from release. meetecho/imquic#43 is acknowledged upstream but still open.

  • Backported fix(net): write IETF data stream headers in one write #6504 to release as moq-dev/moq#6769 (JS-only, no API or wire change). Against the runner's imquic relay image, the runner's client fails 2/2 on 0.4.4 and passes 3/3 on the backport branch.
  • Rewrote the quest into a condition like JS namespace lifecycle: once a 0.4.7+ patch ships with the backport, bump the runner's client and delete the quest. An imquic fix plus a runner image rebuild also clears it.
  • Moved the main-only note (an announced request asks SUBSCRIBE_NAMESPACE for its exact path, so a moq-transport relay never reports the shorter routing prefix) to Runner client bump, the quest that moves the client to main's cut. Otherwise the note would go when this quest is deleted.

Public API: none. Wire: none.

Choices

Checks

  • quest check and quest check --base origin/main: pass.
  • just check: pass.

Follow-ups

  • The runner's moq-dev-js announce-subscribe times out against imquic on both 0.4.4 and the backport ("waiting for broadcast"), so it predates this. Worth classifying in the interop audit.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

…am header

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title JS subgroup data reaches the subscriber through imquic chore(quest): wait on the release backport of the one-write data stream header Oct 25, 2026
@kixelated
kixelated marked this pull request as ready for review October 25, 2026 09:14
@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8152c9af-99bb-4ce2-ac75-9fd21a3f374e
Commits

Reviewing files that changed from the base of the PR and between 66af723 and bf7a4f8.

Files selected for processing: 3
  • quest/m1/interop-coverage/README.md
  • quest/m1/interop-coverage/js-imquic-objects.md
  • quest/m2/release/runner-client-bump.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T09:15:32.548405Z bf7a4f8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: bf7a4f8

No actionable bugs found in this tracking update. Separating the release-line header-write backport from main's announcement-discovery migration is the right direction. The release prerequisite explicitly requires a version carrying #6769, and the main-only shorter-prefix discovery caveat remains recorded rather than disappearing with this quest. The proposed discovery alternatives are correctly labeled untested.

Verification: static review of the changed quests, #6769's backport and the main/release origin request behavior. I did not verify npm publication, external runner or imquic status, or execute interoperability tests.

@kixelated
kixelated added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit 7e3d92e Oct 25, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m1/interop-coverage/js-imquic-objects branch October 25, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant