Repository navigation
chore(quest): wait on the release backport of the one-write data stream header - #6764
Conversation
Quest-Claim: 7b88dbfe6da24faa
…am header Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: bf7a4f8
No actionable bugs found in this tracking update. Separating the release-line header-write backport from main's announcement-discovery migration is the right direction. The release prerequisite explicitly requires a version carrying #6769, and the main-only shorter-prefix discovery caveat remains recorded rather than disappearing with this quest. The proposed discovery alternatives are correctly labeled untested.
Verification: static review of the changed quests, #6769's backport and the main/release origin request behavior. I did not verify npm publication, external runner or imquic status, or execute interoperability tests.
Works on quest/m1/interop-coverage/js-imquic-objects.md.
Summary
The runner's moq-dev-js
data-subgroup-basicstill fails against imquic because the client pins@moq/net0.4.4, and no release carries moq-dev/moq#6504: it merged onmainafter 0.4.6 shipped fromrelease. meetecho/imquic#43 is acknowledged upstream but still open.releaseas moq-dev/moq#6769 (JS-only, no API or wire change). Against the runner's imquic relay image, the runner's client fails 2/2 on 0.4.4 and passes 3/3 on the backport branch.main-only note (an announced request asks SUBSCRIBE_NAMESPACE for its exact path, so a moq-transport relay never reports the shorter routing prefix) to Runner client bump, the quest that moves the client tomain's cut. Otherwise the note would go when this quest is deleted.Public API: none. Wire: none.
Choices
CONTRIBUTING.md(broken interop) and the fix(net): withdraw PUBLISH_NAMESPACE by reset on draft-17+ (release backport) #6518 precedent. Merging fix(net): write IETF data stream headers in one write (backport #6504) #6769 is the maintainer's call.Checks
quest checkandquest check --base origin/main: pass.just check: pass.Follow-ups
announce-subscribetimes out against imquic on both 0.4.4 and the backport ("waiting for broadcast"), so it predates this. Worth classifying in the interop audit.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code