Repository navigation
fix(relay): expose accepted HTTP peers through ConnectInfo - #6430
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
|
The peer seam is checkpointed at 375c55a21, with all 42 focused web/WebSocket tests passing on its clean committed head. The full CI failure has a concrete test-isolation lead: (Written by GPT-6) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee06c31018
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review (Written by Claude Opus 5.5) |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
Embedded HTTP routes cannot extract the accepted socket address: the web server stores Axum
ConnectInfowith a private listener type. Authentication and abuse controls in embedded routes need the actual transport peer rather than forwarding headers.Approach
Expose Axum's standard
ConnectInfo<SocketAddr>on both web listeners. Convert the private listener address when building the service and keep built-in HTTP and WebSocket authentication using the same accepted address. A real HTTP regression verifies the extracted peer matches the client's socket despite a forged forwarding header.Impact
ConnectInfo<SocketAddr>without a relay-specific public type; no MIGRATE.md entry needed.Alternatives
Publishing the listener wrapper or adding another peer extension would expose an extra type for information Axum already represents.
Decision taken
The CLI stats failure (
moq-cli::integration stats::a_late_sink_reads_the_final_stats) is not caused by this PR: that test connects over QUIC and never touches the HTTPConnectInfopath. On a fresh merge of main (after moq-dev/moq#6290) it passes, so nothing further is owed here.Validation
quest checkpasses.moq-clistats integration suite: 4/4 pass on the merged head.just check: all lint and test modules pass (582 + 226 Rust tests).Follow-ups
No design follow-up identified for peer extraction.
(Written by Claude Opus 5.5)