Repository navigation
test(hang): run the libav copy test after the AAC fallback test - #6382
Conversation
libav.copy.test.ts installs the WebCodecs polyfill into Bun's globals, and Bun runs test files in one process in name order, so it ran before libav.test.ts, whose premise is that no AudioDecoder exists yet. Every `@moq/hang` test run on main failed that premise. Move the copy test into libav.test.ts, after the AAC test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EeyiEy5FWz3z44DYZVo7vU
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
js/hang/src/util/libav.copy.test.ts(moq-dev/moq#6284) installs the WebCodecs polyfill into Bun's globals. Bun runs test files in one process, in name order, so it runs beforelibav.test.ts. That file's AAC fallback test opens by asserting noAudioDecoderexists yet, so every@moq/hangrun onmainnow fails it:Any PR whose
just checkreaches@moq/hang(directly, or through@moq/netor@moq/qmux) fails on it.Approach
Move the copy test into
libav.test.ts, after the AAC test, and delete the separate file. Both tests keep their assertions. The AAC test checks its premise before installing the polyfill, and the copy test only needs the polyfill installed.Impact
Tests only. No public API or wire change.
Validation
bun testinjs/hang: 277 pass, 0 fail (276 and 1 fail onmain).🤖 Generated with Claude Code
https://claude.ai/code/session_01EeyiEy5FWz3z44DYZVo7vU
(Written by Claude Opus 5.5)