Skip to content

ci: skip flake checks for Rust source-only changes - #6412

Merged
kixelated merged 1 commit into
mainfrom
perf/queue-nix-scope
Oct 23, 2026
Merged

kixelated merged 1 commit into
mainfrom
perf/queue-nix-scope

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Every Rust source edit selects nix flake check, including evaluation and runner VM checks that the edit cannot affect. One observed warm check took 77.44 seconds locally. Conversely, Python and shell helpers under nix/runner/ do not select those checks.

Approach

Select the full flake check for Nix modules and helpers, Cargo metadata, native library lists, packaging templates, PTX assets, and toolchain changes. Rust source edits retain their existing lint, compile, and test gates. Full gates still select every module.

Extend dispatcher execution tests to check the commands selected for each input category, including --all.

Impact

  • CI routing only; no public API, wire format, or package version changes.
  • Rust source-only diffs omit the Nix phase. Nix and packaging inputs retain the full check.

Alternatives

--no-build would retain expensive evaluation of unrelated runner checks. Keeping the original route also retains unrelated VM failures on Rust-only work.

Validation

Tested head: e382251ed.

Follow-ups

None beyond the required merge-queue validation.

(written by GPT-6)

Skip Nix evaluation and runner VM checks for Rust source-only edits. Keep Cargo metadata and packaging assets covered, and include runner helper scripts and toolchain changes in the Nix gate.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 23:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T23:36:28.216069Z e382251 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0aca69da-8e9e-420f-aa90-cf4f857f7836
📥 Commits

Reviewing files that changed from the base of the PR and between 34b6ceb and e382251.

📒 Files selected for processing: 3
  • flake.nix
  • sh/dispatch-query.test.py
  • sh/dispatch.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 96e278f Oct 23, 2026
10 checks passed
@kixelated
kixelated deleted the perf/queue-nix-scope branch October 23, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant