Repository navigation
ci: skip flake checks for Rust source-only changes - #6412
Conversation
Skip Nix evaluation and runner VM checks for Rust source-only edits. Keep Cargo metadata and packaging assets covered, and include runner helper scripts and toolchain changes in the Nix gate. Co-Authored-By: GPT-6 <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Every Rust source edit selects
nix flake check, including evaluation and runner VM checks that the edit cannot affect. One observed warm check took 77.44 seconds locally. Conversely, Python and shell helpers undernix/runner/do not select those checks.Approach
Select the full flake check for Nix modules and helpers, Cargo metadata, native library lists, packaging templates, PTX assets, and toolchain changes. Rust source edits retain their existing lint, compile, and test gates. Full gates still select every module.
Extend dispatcher execution tests to check the commands selected for each input category, including
--all.Impact
Alternatives
--no-buildwould retain expensive evaluation of unrelated runner checks. Keeping the original route also retains unrelated VM failures on Rust-only work.Validation
Tested head:
e382251ed.just fix origin/mainpasses.just ci origin/mainpasses, including the full Nix check. The JS phase stopped at the unchanged AAC test-order failure fixed by test(hang): run the libav copy test after the AAC fallback test #6382, now merged. Reproduced that failure directly on the unchanged files and independently validated test(hang): run the libav copy test after the AAC fallback test #6382 with its passing scoped CI.just rs test-changed --allpasses 9,666 default, 513 media-feature, and 223 CLI-feature tests;just py testpasses all 104 tests.main, including test(hang): run the libav copy test after the AAC fallback test #6382, before landing this PR.Follow-ups
None beyond the required merge-queue validation.
(written by GPT-6)