Skip to content

fix(ci): clear stale Pages artifacts before report reruns - #6207

Merged
kixelated merged 4 commits into
mainfrom
quest/m1/ci-housekeeping
Oct 22, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m1/ci-housekeeping

Conversation

@kixelated

@kixelated kixelated commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Rerunning nightly benchmark-site or smoke relays-report leaves the earlier attempt's github-pages artifact beside the new upload, so Pages deployment cannot select one.

Approach

Both existing report publishers call just gh pages-clean before uploading. The shared helper lists every matching artifact in the current workflow run before deleting it, fails on API errors, and requires actions: write only in those publishing jobs. Four regression cases cover first attempts, multiple earlier attempts, and listing/deletion failures; they run in the existing nightly tooling suite.

Impact

  • Public API: none. Wire: none.
  • Consumers: the existing nightly benchmark site and public relay report reruns.

Alternatives

Duplicating cleanup inline would bypass the repository's shared recipe convention. The helper does not edit the in-flight interop report implementation in moq-dev/moq#6180.

Follow-ups

Out of scope here: the narrowed quest/m1/ci-housekeeping.md keeps two quest-level conditions that this PR does not depend on:

  • Leave queue concurrency unchanged until loaded validation passes. At 24 workers on eight CPUs, the first Rust run stopped after 1,870 tests with two CLI failures, recorded in the quest. moq-dev/moq#6113 already edits the redundant-importer tests.
  • The dev shell and latest upstream actionlint release are still 1.7.12. Remove the queue-key ignore after the supporting release reaches nixpkgs.

Validation

  • just ci: passes after rebasing onto main's quest-link repair.
  • Pass: just gh check, four artifact cleanup regression cases, Markdown/shell/TOML/Nix and recipe formatting checks, and git diff --check.
  • No live artifact deletions or deployments were performed.

(Written by GPT-6)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Quest outcome: the stale Pages artifact cleanup is implemented and locally validated; queue oversubscription and the actionlint release condition remain in the narrowed quest. The 24-worker stress proof failed the two CLI tests recorded in the body, so the queue setting was not changed. The scoped gate remains blocked by the base quest links already fixed in moq-dev/moq#6205.

This PR stays draft for the remaining conditions. No merge, queue action, review request, or live artifact deletion was performed.

(Written by GPT-6)

kixelated and others added 2 commits October 21, 2026 15:10
Co-Authored-By: GPT-6 <noreply@openai.com>
Share run-scoped artifact cleanup between nightly and relay report publishers. Retain queue oversubscription until loaded validation passes, plus the actionlint release condition.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated force-pushed the quest/m1/ci-housekeeping branch from ae90c01 to 33fe04c Compare October 21, 2026 22:12
@kixelated

Copy link
Copy Markdown
Collaborator Author

Rebased onto main after the quest-link fix merged and reran nix develop --command just ci: passed. This remains draft because the retained quest still needs the 24-worker proof and an available actionlint release newer than 1.7.12.

(Written by GPT-6)

@kixelated
kixelated marked this pull request as ready for review October 21, 2026 22:48
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dae0566b-a079-4605-bdd8-4347793993d3
📥 Commits

Reviewing files that changed from the base of the PR and between bce217e and c035181.

📒 Files selected for processing: 8
  • .github/justfile
  • .github/workflows/interop.yml
  • .github/workflows/nightly.yml
  • .github/workflows/smoke.yml
  • quest/m1/README.md
  • quest/m1/ci-housekeeping.md
  • sh/gh/pages-clean.sh
  • sh/gh/pages-clean.test.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-22T05:45:15.849095Z c035181 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: both Pages report publishers (nightly benchmark-site, smoke relays-report) now delete this run's earlier github-pages artifacts via just gh pages-clean before uploading, with actions: write scoped to those two jobs. The quest is narrowed to the remaining queue-thread validation and actionlint-ignore removal.

  • Review: Codex completed on 33fe04c7d2ccef7108054c525dbea0b2deab5f05 with no findings. CodeRabbit was rate-limited (optional).
  • Local: python3 sh/gh/pages-clean.test.py (4 pass) and nix develop --command just gh check pass on the head.
  • No decisions outstanding; enabling auto-merge on the head SHA. The required Check runs in the merge queue.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge October 21, 2026 23:00
Resolve the .github/justfile conflict with #6180 by keeping both
pages-publish and pages-clean, and switch interop's inline Pages
artifact cleanup to the shared helper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated added this pull request to the merge queue Oct 21, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Update: moq-dev/moq#6180 merged right after auto-merge was enabled and conflicted in .github/justfile. Merged origin/main (head 28d901e5eaee512cf08acce5634280b1e5218cec), kept both pages-publish and pages-clean, and switched interop's inline Pages artifact cleanup to just gh pages-clean, so all three Pages publishers share the reviewed helper. just gh check, the 4 cleanup tests, and quest check pass. Auto-merge stays enabled.

(Written by Claude Opus 5.5)

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 22, 2026
@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 22, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Update: the PR left the merge queue twice.

  • 02:32Z (failed_checks): the queue group failed check quest on quest/m1/audit-ci.md:111: link does not resolve: /quest/m0/audit-perf.md, a main-side link this PR does not touch. Main has since fixed it; quest check passes on the merged tree.
  • 04:55Z: a conflict with main in quest/m1/README.md. Merged origin/main (head c035181dddc2774bae0b404a5be7b351b4bf738d), keeping main's list and this PR's narrowed CI housekeeping line. The Smoke flake bumps entry is dropped because moq-dev/moq#6210 finished and deleted that quest.

The resolution is quest-only, so the prior review still covers the code. nix develop --command just check passed locally. Re-enabling auto-merge.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit c78547e Oct 22, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m1/ci-housekeeping branch October 22, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant