Repository navigation
fix(ci): clear stale Pages artifacts before report reruns - #6207
Conversation
|
Quest outcome: the stale Pages artifact cleanup is implemented and locally validated; queue oversubscription and the actionlint release condition remain in the narrowed quest. The 24-worker stress proof failed the two CLI tests recorded in the body, so the queue setting was not changed. The scoped gate remains blocked by the base quest links already fixed in moq-dev/moq#6205. This PR stays draft for the remaining conditions. No merge, queue action, review request, or live artifact deletion was performed. (Written by GPT-6) |
Co-Authored-By: GPT-6 <noreply@openai.com>
Share run-scoped artifact cleanup between nightly and relay report publishers. Retain queue oversubscription until loaded validation passes, plus the actionlint release condition. Co-Authored-By: GPT-6 <noreply@openai.com>
ae90c01 to
33fe04c
Compare
|
Rebased onto main after the quest-link fix merged and reran (Written by GPT-6) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary: both Pages report publishers (nightly
(Written by Claude Opus 5.5) |
Resolve the .github/justfile conflict with #6180 by keeping both pages-publish and pages-clean, and switch interop's inline Pages artifact cleanup to the shared helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Update: moq-dev/moq#6180 merged right after auto-merge was enabled and conflicted in (Written by Claude Opus 5.5) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Update: the PR left the merge queue twice.
The resolution is quest-only, so the prior review still covers the code. (Written by Claude Opus 5.5) |
Problem
Rerunning nightly
benchmark-siteor smokerelays-reportleaves the earlier attempt'sgithub-pagesartifact beside the new upload, so Pages deployment cannot select one.Approach
Both existing report publishers call
just gh pages-cleanbefore uploading. The shared helper lists every matching artifact in the current workflow run before deleting it, fails on API errors, and requiresactions: writeonly in those publishing jobs. Four regression cases cover first attempts, multiple earlier attempts, and listing/deletion failures; they run in the existing nightly tooling suite.Impact
Alternatives
Duplicating cleanup inline would bypass the repository's shared recipe convention. The helper does not edit the in-flight interop report implementation in moq-dev/moq#6180.
Follow-ups
Out of scope here: the narrowed
quest/m1/ci-housekeeping.mdkeeps two quest-level conditions that this PR does not depend on:Validation
just ci: passes after rebasing onto main's quest-link repair.just gh check, four artifact cleanup regression cases, Markdown/shell/TOML/Nix and recipe formatting checks, andgit diff --check.(Written by GPT-6)