Skip to content

fix(test): use Nix Chromium for Playwright checks - #6216

Merged
kixelated merged 5 commits into
mainfrom
quest/m1/playwright-nix
Oct 22, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m1/playwright-nix

Conversation

@kixelated

@kixelated kixelated commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Developers and CI running the browser interop, video, p2p, WASM, audio-quality and browser benchmark harnesses need the same runnable Chromium. Downloaded Playwright browsers fail on NixOS and can drift from nixpkgs.

Approach

The root devShell provides Chromium and its browser path/version. Pin all six root-workspace npm clients exactly to Nix's Playwright (1.64.1 with main's current nixpkgs) and enforce every in-tree manifest during JS checks, including after root Nix input changes. Remove Chromium downloads from recipes/workflows and update contributor instructions. Clear desktop display variables for the headless software-Vulkan video fixture.

Smoke keeps its independent flake and freshness check. The dedicated Firefox job retains its downloaded engines in a writable runner temp directory. Complete and remove quest/m1/playwright-nix.md.

Impact

  • Public API and wire: none.
  • Current consumers: the browser harnesses above, locally and in their existing CI jobs. Root shells now include the browser closure; the six npm pins match it exactly.
  • Dependabot no longer bumps root npm playwright: an npm-only bump would fail the pin check and stall the whole bun group. A nixpkgs bump that moves playwright-driver fails the JS pin check until the six manifests and bun.lock follow, pushed onto that Nix update.

Alternatives

Keep downloaded browsers plus manual runtime-library setup, or maintain separate local and CI browser installations. Both retain the drift this quest removes.

Checks

  • Real Nix Chromium (on the 1.63.0 pin, before the merge): JS-to-JS interop; p2p browser transport; all five video renderer cases; Rust browser clock with and without default features.
  • All JS tests, five pin checker regressions, dispatch regressions, workflow syntax/policy, shell/Markdown/Nix/recipe formatting and quest validation pass.
  • After merging main (nixpkgs now ships Playwright 1.64.1): pins moved to 1.64.1, bun.lock regenerated, the pin checker and its tests, quest check, and every just check module pass except flake, which stops at the same runner VM image build below.
  • Local just ci cannot build the runner VM image on the authoring host (systemd-repart cannot write /proc/self/uid_map), a host restriction unrelated to this change; the merge queue's CI is the full gate.

Follow-ups

An independent baseline fixture in sh/js/workspace.test.py also calls chmod before creating its tools/just; no source change here depends on that test. Existing Pages artifact cleanup in moq-dev/moq#6207 is untouched.

(Written by GPT-6, updated by Claude Opus 5.5)

kixelated and others added 2 commits October 21, 2026 15:12
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

The scoped implementation is complete. All JS tests, all five pin-check regressions, dispatch regressions and focused formatting/workflow/quest checks pass. Actual Nix Chromium passed JS interop, p2p, all five video cases and both Rust browser-clock configurations.

Keep this draft: the full just ci stops at the baseline runner-image build's unavailable user-namespace capability (/proc/self/uid_map). The base evaluates the identical image derivation. No API/wire decisions remain. A host with that capability must run the remaining full gate; the independent existing nightly workspace-test fixture also needs repair outside this quest.

(Written by GPT-6)

kixelated and others added 2 commits October 21, 2026 23:01
Pin the six root-workspace Playwright clients to 1.64.1, the version main's nixpkgs bump ships.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The six root-workspace Playwright pins must equal the root flake's browser, so an npm-only bump would fail the pin check and block the whole bun group.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 06:20
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b0fa4960-ece6-4c25-bfed-fc524e8466bb
📥 Commits

Reviewing files that changed from the base of the PR and between 2d73eea and 92c80d6.

⛔ Files ignored due to path filters: 1
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing: 32
  • .github/dependabot.yml
  • .github/workflows/interop.yml
  • .github/workflows/nightly.yml
  • .github/workflows/video.yml
  • .github/workflows/wasm.yml
  • bench/browser/package.json
  • bench/browser/run.sh
  • flake.nix
  • js/justfile
  • quest/m1/README.md
  • quest/m1/playwright-nix.md
  • rs/justfile
  • sh/dispatch-query.test.py
  • sh/dispatch.sh
  • sh/js/README.md
  • sh/js/playwright.py
  • sh/js/playwright.test.py
  • sh/js/workspace.py
  • test/audio-quality/clients/js/package.json
  • test/audio-quality/record.sh
  • test/audio-quality/run.sh
  • test/interop/README.md
  • test/interop/clients/js/package.json
  • test/interop/interop.sh
  • test/justfile
  • test/p2p/package.json
  • test/portrait/run.sh
  • test/video/package.json
  • test/video/renderer.browser.ts
  • test/wasm/README.md
  • test/wasm/package.json
  • test/wasm/run.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T09:55:53.549758Z 92c80d6 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 22, 2026
Keep the exact Playwright 1.64.1 pins matching Nix's playwright-driver
over main's ^1.64.1 bump, and regenerate bun.lock in the dev shell.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main after the queue dropped this for a conflict with the bun group bump (moq-dev/moq#6265), which moved the six Playwright clients to ^1.64.1. Kept this PR's exact 1.64.1 pins (Nix playwright-driver is still 1.64.1 after main's nixpkgs bump) and regenerated bun.lock in the dev shell; the lock differs from main only in those six specifiers. Pin checker, its tests, dispatch tests, just js check, and quest check --base origin/main pass. Re-queued at 92c80d6.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 4513b8c Oct 22, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m1/playwright-nix branch October 22, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant