Repository navigation
fix(test): use Nix Chromium for Playwright checks - #6216
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
|
The scoped implementation is complete. All JS tests, all five pin-check regressions, dispatch regressions and focused formatting/workflow/quest checks pass. Actual Nix Chromium passed JS interop, p2p, all five video cases and both Rust browser-clock configurations. Keep this draft: the full (Written by GPT-6) |
Pin the six root-workspace Playwright clients to 1.64.1, the version main's nixpkgs bump ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The six root-workspace Playwright pins must equal the root flake's browser, so an npm-only bump would fail the pin check and block the whole bun group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Keep the exact Playwright 1.64.1 pins matching Nix's playwright-driver over main's ^1.64.1 bump, and regenerate bun.lock in the dev shell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged (Written by Claude Opus 5.5) |
Problem
Developers and CI running the browser interop, video, p2p, WASM, audio-quality and browser benchmark harnesses need the same runnable Chromium. Downloaded Playwright browsers fail on NixOS and can drift from nixpkgs.
Approach
The root devShell provides Chromium and its browser path/version. Pin all six root-workspace npm clients exactly to Nix's Playwright (1.64.1 with main's current nixpkgs) and enforce every in-tree manifest during JS checks, including after root Nix input changes. Remove Chromium downloads from recipes/workflows and update contributor instructions. Clear desktop display variables for the headless software-Vulkan video fixture.
Smoke keeps its independent flake and freshness check. The dedicated Firefox job retains its downloaded engines in a writable runner temp directory. Complete and remove
quest/m1/playwright-nix.md.Impact
playwright: an npm-only bump would fail the pin check and stall the whole bun group. A nixpkgs bump that movesplaywright-driverfails the JS pin check until the six manifests andbun.lockfollow, pushed onto that Nix update.Alternatives
Keep downloaded browsers plus manual runtime-library setup, or maintain separate local and CI browser installations. Both retain the drift this quest removes.
Checks
bun.lockregenerated, the pin checker and its tests,quest check, and everyjust checkmodule pass exceptflake, which stops at the same runner VM image build below.just cicannot build the runner VM image on the authoring host (systemd-repartcannot write/proc/self/uid_map), a host restriction unrelated to this change; the merge queue's CI is the full gate.Follow-ups
An independent baseline fixture in
sh/js/workspace.test.pyalso callschmodbefore creating itstools/just; no source change here depends on that test. Existing Pages artifact cleanup in moq-dev/moq#6207 is untouched.(Written by GPT-6, updated by Claude Opus 5.5)