Skip to content

quest(m2): fold mp4-atom dOps mapping into CMAF surround Opus - #5891

Merged
kixelated merged 1 commit into
mainfrom
quest/m2/fold-dops-mapping
Oct 18, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/m2/fold-dops-mapping

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

quest/m2/mp4-atom-dops-mapping.md (draft #5819) would land a breaking mp4-atom 0.17 (kixelated/mp4-atom#246) whose only standalone effect here is swapping mp4-atom's generic decode error for UnsupportedMappingFamily. The payoff is surround Opus, which is a separate quest.

Approach

Decision prompt (maintainer, this session):

Impact

  • Quest tree only. No public API or wire change.

Alternatives

Follow-ups

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

The mp4-atom dOps change only pays off with surround Opus, so its breaking
0.17 release lands with that work in one moq PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: af03f0ba-95ae-447f-bd57-f34da8edfc2b
📥 Commits

Reviewing files that changed from the base of the PR and between 0c954f5 and a2c17e7.

📒 Files selected for processing: 3
  • quest/m2/README.md
  • quest/m2/cmaf-opus-surround.md
  • quest/m2/mp4-atom-dops-mapping.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T04:27:10.843022Z a2c17e7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Enqueuing. Codex reviewed a2c17e7 with no findings. Summary: the mp4-atom dOps quest is folded into quest/m2/cmaf-opus-surround.md (now [M]), so the breaking mp4-atom 0.17 (kixelated/mp4-atom#246) lands only with surround Opus, in one moq PR. #246's Dops shape and field name stay open for that PR, with recommendations. #5819 is closed.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 18, 2026
Merged via the queue into main with commit d75521e Oct 18, 2026
7 checks passed
@kixelated
kixelated deleted the quest/m2/fold-dops-mapping branch October 18, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant