Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mp4-atom now decodes any dOps channel mapping family (kixelated/mp4-atom#246), so the Opus importer can no longer rely on it refusing a table. Refuse one explicitly until surround import lands, and point the workspace at the mp4-atom branch until it releases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Started unattended from the quest. Library work is in kixelated/mp4-atom#246 (draft). This PR stays a draft until #246 releases and the temporary branch patch becomes (Written by Claude Opus 5.5) |
|
Closing in favor of folding this quest into (Written by Claude Opus 5.5) |
Finishes
quest/m2/mp4-atom-dops-mapping.md. The library work is kixelated/mp4-atom#246; this PR is the consumer side and the bump.Changes
Dopsdecodes and encodes any channel mapping family aschannel_mapping: Option<OpusChannelMapping>(Noneis family 0), checking the table against the output channel count and the RFC 7845 §5.1.1 stream rules on both paths. Family 0 encodes byte-identically.opus::Error::UnsupportedMappingFamily, so a surround track is never imported as stereo with its table dropped. The regression test builds a real family 1dOpsand fails without the check.channel_mapping: None; it already refuses a description with a table.quest/m2/cmaf-opus-surround.md, whose plan now names both refusals to replace.Remaining before ready
The workspace temporarily patches
mp4-atomto thedops-channel-mappingbranch, whichcargo denyrefuses (unknown-git = "deny"), so CI will fail on that. Once #246 merges and release-plz cuts 0.17.0, replace the patch withmp4-atom = "0.17"inrs/moq-mux/Cargo.toml.Public API and wire impact
dOpsmapping table fails withUnsupportedMappingFamilyinstead of mp4-atom's generic decode error.Dops::channel_mappingfield andOpusChannelMappingtype.Open decisions
Dopsshape (in Make some automation for publishing NPM packages. #246). Recommended:Option<OpusChannelMapping>besideoutput_channel_count. Alternatives: a flatchannel_mapping_family: u8plus an optional table, which mirrors the spec but allows family 0 with a table; or an enum replacingoutput_channel_count, which drops the redundant count but breaks every caller harder.channel_mapping, mirroring the spec. Alternative:table, which reads better at call sites.Checks
cargo check,clippy -D warnings,fmt --check, andcargo test --all-targetswith and without--all-features.just checkpasses against the patched branch; the new regression test fails without the import check.cargo deny check sourcesfails on the temporary patch, as expected.Follow-ups
quest/m2/cmaf-opus-surround.mdis unblocked once this lands: import and export the table throughopus::Mapping.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code