Skip to content

RUBY-3981 Fix Lint/NextWithoutAccumulator violations #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamis merged 1 commit into from
Oct 15, 2026
Merged

RUBY-3981 Fix Lint/NextWithoutAccumulator violations #3113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ Lint/IncompatibleIoSelectWithFiberScheduler:
- 'lib/mongo/socket/ssl.rb'
- 'lib/mongo/socket/tcp.rb'

# Offense count: 2
Lint/NextWithoutAccumulator:
Exclude:
- 'lib/mongo/operation/shared/result/aggregatable.rb'

# Offense count: 12
Lint/RescueException:
Exclude:
Expand Down
6 changes: 3 additions & 3 deletions lib/mongo/operation/shared/result/aggregatable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def aggregate_write_errors(count)
return unless @replies

@replies.reduce(nil) do |errors, reply|
next unless (write_errors = reply.documents.first['writeErrors'])
next errors unless (write_errors = reply.documents.first['writeErrors'])

wes = write_errors.collect do |we|
we.merge!('index' => count + we['index'])
Expand All @@ -59,11 +59,11 @@ def aggregate_write_concern_errors(count)
return unless @replies

@replies.each_with_index.reduce(nil) do |errors, (reply, _)|
next unless (write_concern_errors = reply.documents.first['writeConcernErrors'])
next errors unless (write_concern_errors = reply.documents.first['writeConcernErrors'])

(errors || []) << write_concern_errors.reduce(nil) do |errs, wce|
wce.merge!('index' => count + wce['index'])
(errs || []) << write_concern_error
(errs || []) << wce
end
end
end
Expand Down
Loading