Repository navigation
RUBY-3981 Fix Lint/NextWithoutAccumulator violations - #3113
Merged
Merged
Conversation
Pass the accumulator to next in the reduce blocks of Operation::Result::Aggregatable, then remove the cop's exclusion from .rubocop_todo.yml. Also fix a typo in aggregate_write_concern_errors: write_concern_error is not defined; use the block variable wce.
comandeo-mongo
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up Lint/NextWithoutAccumulator by passing the accumulator to next in the reduce blocks of Operation::Result::Aggregatable, then removes the cop from .rubocop_todo.yml.
While in there I noticed that write_concern_error on line 66 is not defined anywhere, so I switched it to the block variable wce.