Repository navigation
deps(core, ts-plugin, codegen, stylelint-plugin, eslint-plugin): move the code shared by ts-plugin and codegen to the new core-strada package - #466
Merged
Conversation
🦋 Changeset detectedLatest commit: 5f512d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mizdra
force-pushed
the
claude/core-strada
branch
from
November 1, 2026 15:35
e24312a to
b36424d
Compare
mizdra
force-pushed
the
claude/core-strada
branch
from
November 1, 2026 16:17
b36424d to
f009071
Compare
mizdra
marked this pull request as ready for review
November 1, 2026 16:58
mizdra
force-pushed
the
claude/core-strada
branch
3 times, most recently
from
November 3, 2026 04:14
53161d4 to
0aed046
Compare
… the code shared by ts-plugin and codegen to the new core-strada package Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mizdra
force-pushed
the
claude/core-strada
branch
from
November 3, 2026 04:32
0aed046 to
5f512d2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #377
Background
css-modules-kit is working on supporting TypeScript 7+. Specifically, the following changes are planned:
@css-modules-kit/content-mapper*.module.css@css-modules-kit/codegenand@css-modules-kit/ts-plugin@css-modules-kit/eslint-pluginand@css-modules-kit/stylelint-pluginusable without installing TypeScriptThe blocker for these changes is that
@css-modules-kit/coredepends ontypescript6 or earlier.@css-modules-kit/coreis depended on by@css-modules-kit/eslint-pluginand@css-modules-kit/stylelint-plugin(and by@css-modules-kit/content-mapperin the future). So@css-modules-kit/coremust stop depending ontypescript6 or earlier.Approach
Move the code shared by ts-plugin and codegen, the tools that run on the API of TypeScript 6 or earlier, to a new package,
@css-modules-kit/core-strada. Then remove thetypescriptpeer dependency from@css-modules-kit/core.Changes
@css-modules-kit/core-strada. The following moved there from@css-modules-kit/core:tsconfig.json.d.tsfiles@css-modules-kit/corekeeps parsing CSS modules and finding component files, and no longer hastypescriptas a peer dependencycore-stradain addition tocoretypescriptincorenode:pathdirectly incore, stylelint-plugin, eslint-plugin and content-mapperFuture work
stylelint-plugin and eslint-plugin have been depending on the API of
typescript6 or earlier. So they depend oncore-stradaas of this PR. The next PR in this stack will remove that dependency.