Repository navigation
deps(stylelint-plugin, eslint-plugin): stop depending on core-strada from the linter plugins - #470
Merged
Conversation
mizdra
added
the
Type: Dependencies
🦋 Changeset detectedLatest commit: 6f08e38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mizdra
force-pushed
the
claude/linters-without-core-strada
branch
2 times, most recently
from
November 3, 2026 03:30
00ec80a to
6f10f5b
Compare
mizdra
changed the title
mizdra
force-pushed
the
claude/linters-without-core-strada
branch
3 times, most recently
from
November 3, 2026 04:14
93c77dc to
67acfd9
Compare
…from the linter plugins Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mizdra
force-pushed
the
claude/linters-without-core-strada
branch
from
November 3, 2026 04:32
67acfd9 to
6f08e38
Compare
mizdra
changed the title
mizdra
marked this pull request as ready for review
November 3, 2026 05:23
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #377
Background
css-modules-kit is working on supporting TypeScript 7+. Specifically, the following changes are planned:
@css-modules-kit/content-mapper*.module.css@css-modules-kit/codegenand@css-modules-kit/ts-plugin@css-modules-kit/eslint-pluginand@css-modules-kit/stylelint-pluginusable without installing TypeScriptSo #466 split the code for TypeScript 6 or earlier out of
@css-modules-kit/coreinto@css-modules-kit/core-strada. However,@css-modules-kit/eslint-pluginand@css-modules-kit/stylelint-pluginstill depend on@css-modules-kit/core-strada.Approach
@css-modules-kit/eslint-pluginand@css-modules-kit/stylelint-plugindepend on thebasenamefunction of@css-modules-kit/core-strada. This PR replaces it with thebasenamefunction of Node.js.Note that the two functions differ. The
basenamefunction of@css-modules-kit/core-stradaconverts backslashes in the result of the Node.jsbasenamefunction to slashes. So the results differ for a file whose name contains a backslash on Linux and macOS. For example,a\b.tsxbecomesa/b.tsxwith@css-modules-kit/core-stradaand staysa\b.tsxwith Node.js.This difference has almost no impact on users. The result of the
basenamefunction is used only as the file name shown in the message of theno-unused-class-namesrule, so what the rule reports does not change. Only a component file whose name contains a backslash is affected, and its actual file name is shown in the message.Also, the css-modules-kit specification does not define how such a file name is shown in a message. So this change is not considered a breaking change.