Skip to content

fix(release-tracks): temporary ADM validation hotfix - #515

Merged
seansica merged 1 commit into
nextfrom
hotfix/release-track-reviewed
Oct 6, 2026
Merged

seansica merged 1 commit into
nextfrom
hotfix/release-track-reviewed

Conversation

@seansica

@seansica seansica commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Temporary hotfix to enable ADM validation for release-track workloads where each object belongs to exactly one track. It leverages the globally scoped legacy workspace.workflow.state key by validating and marking revisions as reviewed when admitted to staged or members.

A more comprehensive fix is in progress to move ADM validation controls to the track scope.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 94.48276% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.16%. Comparing base (fe39f6e) to head (6b65a2b).

Files with missing lines Patch % Lines
.../services/release-tracks/reviewed-state-service.js 93.75% 4 Missing and 1 partial ⚠️
app/services/release-tracks/versioning-service.js 60.00% 1 Missing and 1 partial ⚠️
app/services/release-tracks/snapshot-service.js 91.66% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #515      +/-   ##
==========================================
+ Coverage   82.11%   82.16%   +0.05%     
==========================================
  Files         256      257       +1     
  Lines       41521    41661     +140     
  Branches     5512     5554      +42     
==========================================
+ Hits        34096    34232     +136     
- Misses       7323     7326       +3     
- Partials      102      103       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@seansica
seansica merged commit 953a7a3 into next Oct 6, 2026
4 checks passed
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 4.24.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants