Repository navigation
chore: roll Playwright to 1.66.0-alpha-1793916328000 - #523
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoNov 5, 2026
Merged
Conversation
Parse the arguments once with parseArgs() and pass them to program(), as microsoft/playwright#43941 allows. The update check now reads the command from the parsed arguments, so a global option with a value before the command no longer hides it.
Pavel Feldman (pavelfeldman)
pushed a commit
that referenced
this pull request
Nov 5, 2026
The update and skill checks took the first non-option token as the command, so `-s foo list` skipped them and `-s list snapshot` ran them. Since #523 the command comes from the parsed arguments. Document the space-separated session forms and extend the update-check and skill-warning tests. Fixes: #505
This was referenced Nov 5, 2026
Pavel Feldman (pavelfeldman)
added a commit
that referenced
this pull request
Nov 5, 2026
## Summary
- The entry point discarded the promise from `program()`, so argument
parsing, startup and daemon validation failures surfaced as unhandled
rejections with a stack trace, and `--json` produced no output.
- Await the program and report a failure as the message on stderr, or `{
"isError": true, "error": "..." }` on stdout in JSON mode, with exit
code 1. The output mode comes from the arguments parsed with the core's
`parseArgs()` (#523), read before `program()` runs; when parsing itself
fails, it falls back to the `--json` flag.
- Extend the open-data-URL test with the text and JSON parse error and a
daemon-side validation error in JSON mode, and document the behavior.
Fixes #502
---------
Co-authored-by: microsoft-playwright-automation[bot] <203992400+microsoft-playwright-automation[bot]@users.noreply.github.com>
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
Pavel Feldman (pavelfeldman)
pushed a commit
that referenced
this pull request
Nov 5, 2026
## Summary - The update and skill checks took the first non-option token as the command, so `-s foo list` skipped them and `-s list snapshot` ran them. Since #523 the command comes from the arguments parsed with the core's `parseArgs()`, which fixes this. - Document the `-s name` and `--session name` forms, and extend the update-check and skill-warning tests: a session before the command warns about a stale skill and checks for updates, `-s list snapshot` makes no registry request and writes no cache, and `--session list install --skills` keeps the install exemption. Fixes #505 Co-authored-by: microsoft-playwright-automation[bot] <203992400+microsoft-playwright-automation[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright,playwright-coreand@playwright/testto1.66.0-alpha-1793916328000.parseArgs()and pass them toprogram(), the embedder contract from feat(cli): let embedders reuse parsed arguments playwright#43941. The update check reads the command from the parsed arguments, so a global option with a value before the command (--session foo list) no longer hides it.running-code.mdnotes that event listener errors are reported as console errors.