Repository navigation
test(cli): cover the session options before the command - #521
Merged
Merged
Conversation
Pavel Feldman (pavelfeldman)
approved these changes
Nov 5, 2026
Pavel Feldman (pavelfeldman)
marked this pull request as ready for review
November 5, 2026 22:40
The update and skill checks took the first non-option token as the command, so `-s foo list` skipped them and `-s list snapshot` ran them. Since #523 the command comes from the parsed arguments. Document the space-separated session forms and extend the update-check and skill-warning tests. Fixes: #505
Pavel Feldman (pavelfeldman)
force-pushed
the
triage/505/42092152959-1
branch
from
November 5, 2026 22:56
1b7ce73 to
4da0a86
Compare
Pavel Feldman (pavelfeldman)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-s foo listskipped them and-s list snapshotran them. Since chore: roll Playwright to 1.66.0-alpha-1793916328000 #523 the command comes from the arguments parsed with the core'sparseArgs(), which fixes this.-s nameand--session nameforms, and extend the update-check and skill-warning tests: a session before the command warns about a stale skill and checks for updates,-s list snapshotmakes no registry request and writes no cache, and--session list install --skillskeeps the install exemption.Fixes #505