Repository navigation
Update/skill check misdetects the command when the session is passed as -s <name> or --session <name> #505
Description
checkForUpdates() in playwright-cli.js takes the first argument not starting with - as the command:
const command = process.argv.slice(2).find(arg => !arg.startsWith('-'));With the space-separated forms the core parser accepts (-s foo, --session foo), that is the session name, not the command.
Steps to reproduce
Using an empty PLAYWRIGHT_CLI_INSTALLATION_FOR_TEST dir and checking whether cli-update-check.json gets written:
| invocation | check ran |
|---|---|
list |
yes |
-s=foo list |
yes |
-s foo list |
no |
--session foo open <url> |
no |
-s list snapshot |
yes (spawns npm view on a non-workflow command) |
Expected
The check runs for open/attach/list/install/install-browser regardless of how the session is passed, and never for other commands.
Suggested fix
Skip the value of -s/--session (and other string globals) when scanning, or parse with the same minimist options program() uses and read args._[0].
Environment
@playwright/cli0.1.23 (main @ f50f579),playwright-core1.65.0-alpha-2026-10-30- Node 22.23.4, Linux x64, Chrome for Testing 153
Activity
github-actions commentedon Nov 5, 2026
microsoft-playwright-automation commentedon Nov 5, 2026
Hi, I'm the Playwright bot and I reproduced this on Linux.
Reproduced on
@playwright/cli0.1.23, main2cbc57d186eb8a70e64ebbd6c923741100c69a9e, withplaywright-core1.65.0-alpha-2026-10-30. The update check mistakes a space-separated session value for the command. The proposed fix uses the core CLI's parser and matching options, so update and skill checks follow the actual command, including the skill-warning exemption forinstall.Reproduction and verification
The existing integration tests use an isolated installation directory and a fake npm registry, with
CIandNO_UPDATE_NOTIFIERcleared:-s foo listomitted the stale-skill warning before the fix; it warns after the fix.-s list snapshotincorrectly requested the latest version before the fix; after the fix it makes no registry request and writes no update-check cache.--session list install --skillsincorrectly warned about the skill being installed before the fix; after the fix it checks for updates without that skill warning.--session foo listrequests the latest version after the fix.--versionremains silent and makes no registry request.All three extended regression tests failed on unchanged main. After the fix,
npm testpasses all nine integration tests, including default headless Chrome navigation, update caching, scoped registries, and registry failure/timeout handling. This is argument parsing before browser dispatch, not an engine-specific issue. No build or lint command exists in this repository.Draft PR: #521
Triaged on Linux by the Playwright bot - agent run
test(cli): cover the session options before the command
test(cli): cover the session options before the command (microsoft#521)