Skip to content

wsl-comfort: point the closing message and readme at names that exist #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmirMS (AmelBawa-msft) merged 1 commit into from
Sep 29, 2026
Merged

wsl-comfort: point the closing message and readme at names that exist #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wsl-comfort/install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,10 +708,10 @@ if ($preBootstrapUser -eq 'root' -or [string]::IsNullOrWhiteSpace($preBootstrapU
Write-Host ' 2. Drop you into zsh with your dotfiles already in place'
Write-Host ' 3. Install Homebrew (a few minutes, one-time)'
Write-Host ''
Write-Host " Open the 'Comfort Shell $sun ($Distro)' profile in Windows Terminal to begin." -ForegroundColor Yellow
Write-Host " Open the 'Comfort Shell - $Distro' profile in Windows Terminal to begin." -ForegroundColor Yellow
} else {
Write-Host ''
Write-Host " Open the 'Comfort Shell $sun ($Distro)' profile in Windows Terminal." -ForegroundColor Yellow
Write-Host " Open the 'Comfort Shell - $Distro' profile in Windows Terminal." -ForegroundColor Yellow
Write-Host " You're already a regular user ($preBootstrapUser); no further setup needed." -ForegroundColor DarkGray
}
Write-Host ''
Expand Down
2 changes: 1 addition & 1 deletion src/wsl-comfort/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ This is what makes the Windows-side flow work on a freshly installed distro that
| **Windows Terminal required** | The script hard-fails if `wt.exe` is not on PATH. A Comfort Shell without a WT profile would be half the experience, so we don't degrade. |
| **WSL install requires a reboot** | First-time WSL installs always reboot. The script registers RunOnce and offers to reboot for you; cancelling the countdown is fine — the auto-resume will fire after any subsequent logon. |
| **Ubuntu only** | Both halves bail on non-Ubuntu distros. Debian would mostly work but is untested; other families would not. |
| **`wsl -l -q` UTF-16 quirk** | `wsl.exe --list --quiet` emits UTF-16LE with embedded NUL bytes. The script strips NULs in `Get-WslSupportedDistros`; do the same in any new code that parses `wsl -l -q`. |
| **`wsl -l -q` UTF-16 quirk** | `wsl.exe --list --quiet` emits UTF-16LE with embedded NUL bytes. The script strips NULs in `Get-InstalledWslDistros`; do the same in any new code that parses `wsl -l -q`. |
| **Homebrew in CI/skel** | Homebrew's installer probes for a real user. In skel mode we defer brew to the first interactive shell; the first user pays a one-time multi-minute cost on first login (logged to `~/.comfort-shell-install.log`). |
| **Clipboard / `open` shims are best-effort** | `pbpaste` strips `\r` from `Get-Clipboard` output; complex clipboard payloads (images, multi-format) won't round-trip. `open` uses `wslpath -w` for files and falls back to passing the raw target for URLs. |
| **`chsh` requires logout** | After the first run, `echo $SHELL` won't reflect zsh until you start a fresh login shell. The Windows Terminal "Comfort Shell" profile starts a fresh shell, so just open it. |
Expand Down