wsl-comfort: point the closing message and readme at names that exist - #120
Merged
AmirMS (AmelBawa-msft) merged 1 commit intoSep 29, 2026
Merged
Conversation
Install-TerminalProfile creates the Windows Terminal profile as "Comfort Shell - <distro>" and prints that name in its summary, but the closing message told the user to open "Comfort Shell 😎 (<distro>)", which does not exist. The readme's caveats table said the NUL stripping for "wsl -l -q" lives in Get-WslSupportedDistros; the function is Get-InstalledWslDistros.
AmirMS (AmelBawa-msft)
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while reading through the wsl-comfort installer: its last line points at a profile name that does not exist.
src/wsl-comfort/install.ps1creates the Windows Terminal profile asComfort Shell - <distro>(Install-TerminalProfile) and printsProfile: Comfort Shell - <distro>in its summary, but the closing message a few lines later tells the user to open'Comfort Shell 😎 (<distro>)', a profile that does not exist. Since it is the last line of the run, it is probably the one people act on.src/wsl-comfort/readme.mdsays the NUL stripping forwsl -l -qlives inGet-WslSupportedDistros. I could not find a function by that name; the stripping is inGet-InstalledWslDistros(Get-SupportedUbuntuDistrosis the other one, a static list that does not parsewsl -l -q).Two
Write-Hoststrings and one readme cell, no behaviour change. Onlysrc/is touched; the signed copy underwsl-comfort/is left to the sign pipeline.Thanks for having a look.