Repository navigation
Integrate new Ethernet - #693
Open
thomas6785 wants to merge 4 commits into
Open
thomas6785 wants to merge 4 commits into
thomas6785 wants to merge 4 commits into
Conversation
Author
|
Leaving this as draft for a moment as I would like to try accessing more PHY registers to test PHY features if I get a chance before leaving (though I am relatively confident if we can access some PHY registers then the rest should be no different) |
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Nice to see the smoke test!
thomas6785
force-pushed
the
ethernet_integrating
branch
2 times, most recently
from
July 31, 2026 12:54
21ad120 to
c834feb
Compare
thomas6785
marked this pull request as ready for review
July 31, 2026 14:53
Author
|
Marking this as ready for review as I am happy with it - however clang is about the smoketest and I don't have the time or the knowledge of C to address this. As far as I can tell it's only stylistic issues (the test passes fine after all) |
marnovandermaas
force-pushed
the
ethernet_integrating
branch
2 times, most recently
from
October 1, 2026 12:02
5bbe5d2 to
31f5324
Compare
marnovandermaas
force-pushed
the
ethernet_integrating
branch
4 times, most recently
from
October 12, 2026 14:18
8ceb488 to
e24a285
Compare
Collaborator
|
Now that CI is passing I think it's best that we merge this pull request. |
marnovandermaas
approved these changes
Oct 12, 2026
New Ethernet IP is vendored in and integrated to the FPGA top A modification is made to gen_xilinx_ip.tcl to enable XPMs The ethernet_wrapper.sv is modified to instantiate the new IP Co-authored-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
Co-authored-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
marnovandermaas
force-pushed
the
ethernet_integrating
branch
from
October 12, 2026 19:18
e24a285 to
8a8c56b
Compare
marnovandermaas
enabled auto-merge
October 12, 2026 19:18
marnovandermaas
disabled auto-merge
October 14, 2026 10:00
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the old Ethernet IP with the new version at lowrisc/ethernet.
A smoke test is included which covers:
The last two of these do not include any checking but it is useful at least to ensure they don't time out