Repository navigation
[lint] Fix Verilator linting and update waivers - #2529
Open
elliotb-lowrisc wants to merge 1 commit into
Open
elliotb-lowrisc wants to merge 1 commit into
elliotb-lowrisc wants to merge 1 commit into
Conversation
Fix Verilator linting for ibex_top by removing incomplete fusesoc filesets override. See lowRISC#2528 Also update the Verilator lint waivers files so that lint passes, and remove in-RTL waivers. The three new waivers are based on an existing three, now ported so they apply generally rather than just ibex_simple_system, and tweaked to match the recent changes to the Ibex core. The in-RTL waivers removed appeared not to do anything, and perhaps were left-over from earlier CHERIoT changes. Signed-off-by: Elliot Baptist <elliot.baptist@lowrisc.org>
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document. By submitting this pull request comment, I am hereby confirming my acceptance of the terms of the CLA Document and my agreement to be legally bound by its terms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Verilator linting for ibex_top by removing incomplete fusesoc filesets override.
See #2528
Also update the Verilator lint waivers files so that lint passes, and remove in-RTL waivers.
The three new waivers are based on an existing three, now ported so they apply generally rather than just ibex_simple_system, and tweaked to match the recent changes to the Ibex core. The in-RTL waivers removed appeared not to do anything, and perhaps were left-over from earlier CHERIoT changes.