Repository navigation
Test the native validator in CI, built against BehaviorTree.CPP - #17
Merged
Merged
Conversation
A second CI job, in a ros:jazzy-ros-base container, builds the native validator against the ROS package of BehaviorTree.CPP, the library and the version, 4.10.0, the commander loads trees with. It runs every test with the real validator, and validates the examples. - tests/native-real.test.ts tests the validator itself: a valid tree, a modelled node, an unknown node, a missing SubTree, an XML syntax error, and the built-in nodes it reports. It runs only where BTCPP_VALIDATOR_REAL names the built program, and is skipped elsewhere. - validator/CMakeLists.txt links to whichever target the library exports: BT::behaviortree_cpp from a build from source, as in the Docker image, behaviortree_cpp::behaviortree_cpp from the ROS package. - The CI badge in the README, and the tests in ARCHITECTURE.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ros:jazzy-ros-basecontainer: it builds the validator against the ROS package of BehaviorTree.CPP, the library and the version (4.10.0) the commander loads trees with, runs every test with the real validator, and validates the examples.tests/native-real.test.ts: the validator itself — a valid tree, a modelled node, an unknown node, a missingSubTree, an XML syntax error, and the built-in nodes it reports. Runs only whereBTCPP_VALIDATOR_REALnames the built program; skipped elsewhere, e.g. in the existing job.validator/CMakeLists.txtlinks to whichever target the library exports:BT::behaviortree_cppfrom a build from source (the Docker image),behaviortree_cpp::behaviortree_cppfrom the ROS package.docs/ARCHITECTURE.md.Until now every test ran against a fake validator, and the comment in
ci.ymlsaid the real one could not be built there.Test plan
acton a clean clone: validator built, 137 tests pass (6 with the real validator), examples valid.🤖 Generated with Claude Code