Repository navigation
Validate the objectives in CI, with the StepIt Editor's validator - #13
Merged
Merged
Conversation
The editor mounted src/plugins/stepit_objectives/objectives itself. A bind mount follows the folder, not its path, and git deletes and recreates a folder when it switches to a branch that lacks it, as gh pr merge did to main before src/plugins existed: the editor then showed the deleted folder, empty, until its container was recreated. It now mounts the repo at ~/rig, as the commander does, and opens the objectives through BEHAVIORS_DIR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new job of ci.yml, objectives, builds the editor's native validator against the ROS package of BehaviorTree.CPP, the library and the version the commander loads trees with, and runs validate on src/plugins/stepit_objectives/objectives: the editor's own checks, then the library loading every file with the node models of the rig's behaviors. A broken objective fails the pull request instead of being refused by the commander on the robot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its native validator builds against the ROS package of BehaviorTree.CPP, which the objectives job needs, and is tested in its CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
objectivesjob inci.yml: builds the StepIt Editor's native validator against the ROS package of BehaviorTree.CPP — the library and the version (4.10.0) the commander loads trees with — and runsvalidateonsrc/plugins/stepit_objectives/objectives: the editor's own checks, then the library loading every file with the node models of the rig's behaviors. A broken objective (unknown node or port, missing subtree, bad XML) fails the pull request instead of being refused by the commander on the robot.gh pr mergeswitched to amainwithoutsrc/plugins, git deleted and recreated the folder, and the running editor showed the deleted one, empty. It now mounts the repo at~/rig, as the commander does, and opens the objectives throughBEHAVIORS_DIR.83a2a03→c4c6d7e(stepit-editor#17): its validator builds against the ROS package, which this job needs.CLAUDE.md: the job, and how to run the same check by hand.Test plan
objectivesjob run withacton a clean clone: 10 files, 0 errors, BehaviorTree.CPP loading each.validate.shin its container finds no error.🤖 Generated with Claude Code