Repository navigation
Move BehaviorTree.ROS2 to the amended fix of our fork - #20
Merged
Merged
Conversation
The fork's humble, kineticsystem/BehaviorTree.ROS2, now holds the amended fix, b0ae01d, which replaces 23dba60: an exception thrown after onTreeCreated(), also by onLoopAfterTick() or onLoopFeedback(), halts the tree and completes the run once, and an exception thrown by onTreeExecutionCompleted() itself does not call it a second time. The submodule and stepit.repos move to it together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 of 3 tasks
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our fork's
humble, kineticsystem/BehaviorTree.ROS2, now holds the amended fix,b0ae01d, in place of23dba60. It is also the head of the upstream pull request BehaviorTree/BehaviorTree.ROS2#135.Compared with
23dba60, the fix now covers any exception thrown afteronTreeCreated(): a node during a tick, oronLoopAfterTick()oronLoopFeedback(). In each case the tree is halted and the run completed with FAILURE. An exception thrown byonTreeExecutionCompleted()itself no longer calls it a second time.modules/BehaviorTree.ROS2andstepit.reposmove tob0ae01dtogether.CLAUDE.mddescribe the wider fix.23dba60, whichmainrecords today, is no longer on any branch of the fork after the force-push; this PR moves off it.Test plan
b0ae01d, in the StepIt Macro image: all 49 tests ofstepit_server_testspass,ATreeThatThrowsEndsItsRunincluded.🤖 Generated with Claude Code