Repository navigation
Move StepIt Commander to the amended fix of BehaviorTree.ROS2 - #70
Merged
Merged
Conversation
The commander builds BehaviorTree.ROS2 from our fork at b0ae01d, the amended fix, which replaces 23dba60: any exception thrown after onTreeCreated(), also by onLoopAfterTick() or onLoopFeedback(), halts the tree and completes the run once. The review's scope and "How a run ends" follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
c33faa6, the branch of Move BehaviorTree.ROS2 to the amended fix of our fork stepit-commander#20. It builds BehaviorTree.ROS2 from our fork atb0ae01d, the amended fix, which replaces23dba60. Any exception thrown afteronTreeCreated(), by a node or byonLoopAfterTick()oronLoopFeedback(), now halts the tree and completes the run, once.Review.md: the scope gives the new commits, and the table of "How a run ends" covers the wider fix.23dba60, whichmainrecords today through the commander at905e802, is no longer on any branch of the fork after its force-push.Before merging: once kineticsystem/stepit-commander#20 is merged, this pointer moves from
c33faa6to the commander's merge commit, so that it records a commit of the commander'smain.Test plan
b0ae01d(Move BehaviorTree.ROS2 to the amended fix of our fork stepit-commander#20)../docker/dock.sh build, restart.🤖 Generated with Claude Code