ASAv loopback

[sdargoeuves]

Depends on #3934, so leaving as a draft.

I was meant to only do the loopback, but I couldn't resist fixing small things for BGP, so we can now have iBGP relationship.

I would appreciate some guidance here: I understand we normally keep one PR per feature/addition/fix, but the ASAv ramp-up will involve several changes, so multiple PRs will likely depend on the previous one.
I’m torn between a larger PR with multiple fixes/improvements, which is potentially harder to review, and multiple smaller ones in a chain. I’d lean towards the larger PR, but I’m happy to do whichever works best.

[ipspace]

I was meant to only do the loopback, but I couldn't resist fixing small things for BGP, so we can now have iBGP relationship.

It would be nice if you could submit loopback-related stuff as a separate (first) PR and then rebase other stuff once that gets merged. I would suggest you do that ASAP before you get further into the weeds ;)

I would appreciate some guidance here: I understand we normally keep one PR per feature/addition/fix, but the ASAv ramp-up will involve several changes, so multiple PRs will likely depend on the previous one.

Yeah, I know how that works...

I’m torn between a larger PR with multiple fixes/improvements, which is potentially harder to review, and multiple smaller ones in a chain. I’d lean towards the larger PR, but I’m happy to do whichever works best.

I prefer smaller PRs (even though they can be a PITA) because that helps our future selves (not to mention our AI friends) understand why a change was made and what problem opportunity we were solving.

[sdargoeuves]

thanks! I'll tidy this PR so it becomes only the loopback addition, and create the following ones as they are ready

[ipspace]

Thank you!