Repository navigation
ASAv iBGP - #3949
Merged
Merged
ASAv iBGP#3949
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new warning is skipped when both same-AS ASAv peers use the default disabled loopbacks.
1 open finding
What changed in this PR
Adds ASAv iBGP support using optional loopback interfaces and BGP update-source configuration.
Changes:
- Adds opt-in loopback configuration.
- Configures BGP neighbor update-source.
- Adds a missing-loopback warning and updates platform caveats.
| File | Description |
|---|---|
| netsim/devices/asav.yml | Defines loopback naming and disabled default. |
| netsim/devices/asav.py | Adds the iBGP loopback warning. |
| netsim/ansible/templates/initial/asa.j2 | Configures loopback interfaces and addresses. |
| netsim/ansible/templates/bgp/asa.macro.j2 | Adds neighbor configuration with update-source. |
| netsim/ansible/templates/bgp/asa.j2 | Uses the new neighbor macro. |
| docs/caveats.md | Documents loopback requirements and limitations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have Loopback (depends on #3946) for ASAv, we can configure the
update-sourcewhich is what was missing for IBGP.I've also added a quirk to warn the user if not using Loopback with IBGP.