You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix: use Simpler namespaces for onboard host helpers - #2976
Name the dedicated scene job by its Torch-NPU dependency. Eager and cold
capture share the same declared environment. Default cases stay in the
onboard job.
Use simpler namespaces for the onboard context and topology helpers and
their in-tree callers.
No actionable comments were generated in the recent review.
Walkthrough
CI now routes A2A3 and A5 Torch-NPU tests through the shared workflow and updates related documentation and tests. A2A3 and A5 AICPU declarations and call sites now use the simpler namespace. The provided summaries report no behavior changes in the host code.
Changes: Torch-NPU CI routing
Layer / File(s)
Summary
Rename and route Torch-NPU jobs .github/actions/setup-framework-eager/action.yml, .github/workflows/_st-npu-a2a3.yml, .github/workflows/_st-torch-npu.yml, .github/workflows/ci-a5-comment.yml, .github/workflows/ci-self.yml, .github/workflows/ci.yml, .github/workflows/daily.yml
Workflow labels and job names now use Torch-NPU terminology. A2A3 and A5 jobs call the shared Torch-NPU workflow, and the A5 comment report uses the renamed job.
Documentation and workflow tests now refer to Torch-NPU jobs and qualification. Documentation describes the shared torch_npu environment for eager and cold-capture cases.
AICPU namespace updates
Layer / File(s)
Summary
Update A2A3 AICPU declarations and callers src/a2a3/platform/onboard/host/*, tests/ut/cpp/a2a3/platform/test_aicpu_affinity_select.cpp, tests/ut/cpp/common/platform/test_native_admission.cpp
A2A3 topology and context-preparation declarations and implementations, device-runner references, and tests now use simpler::a2a3.
A5 topology, context-preparation, device-runner, test, and device-query references now use simpler::a5. The invalid-count test also checks a zero driver count.
hw-native-sys/simpler#2904: This PR updates the Torch-NPU job selection and retains eager and cold-capture cases in that environment.
hw-native-sys/simpler#2666: This PR updates the Torch-NPU CI environment for eager and cold-capture cases and changes A2A3 and A5 host context references.
hw-native-sys/simpler#2670: This PR updates the Torch-NPU CI selection and A2A3/A5 host-side namespace references described by the tracker.
Possibly related PRs
hw-native-sys/simpler#2693: This PR renames the dedicated test jobs added there and routes eager and cold-capture tests through the shared Torch-NPU environment.
A rabbit checks the job names twice, Then hops through A2A3’s namespace change. A5 follows the same trail, Eager and cold-capture share the test lane, And the bunny files the run report.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: d78577b5-c3f6-4859-8792-f3cd6a4eee25
Commits
Reviewing files that changed from the base of the PR and between 20af3c1 and 588ec4b.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChaoWao
changed the title
Summary
simpler::a2a3andsimpler::a5for Simpler's onboard host context preparation, AICPU topology and affinity helpers, and their callers.Validation
Related to #2666 and #2972. Framework environment CI is tracked in #2904 and #2924.