Skip to content

Support json 3 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hogelog merged 3 commits into from
Oct 24, 2026
+4 −3
Merged

Support json 3 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb139e3
Drop quirks_mode from JSON calls in tests
hogelog Oct 23, 2026
0166cd4
Drop create_additions option from JSON.parse
hogelog Oct 23, 2026
cfd3f80
Declare the json dependency
hogelog Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions execjs-pcruntime.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Gem::Specification.new do |spec|
spec.license = 'MIT'

spec.add_dependency 'execjs', '~> 2.0'
spec.add_dependency 'json', '>= 2.0'

# Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
# to allow pushing to a single host or delete this section to allow pushing to any host.
Expand Down
2 changes: 1 addition & 1 deletion lib/execjs/pcruntime/context_process_runtime.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def post_request(socket_path, path, content_type = nil, body = nil)
result = URI.decode_www_form_component response.body

if response.code == '200'
::JSON.parse(result, create_additions: false) if /\S/.match?(result)
::JSON.parse(result) if /\S/.match?(result)
else
# expects ErrorMessage\0StackTrace =~ response.body
message, stack = result.split "\0"
Expand Down
4 changes: 2 additions & 2 deletions test/test_execjs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ def test_context_call_missing_function
{ 'a' => 1, 'b' => [2, 3] },
{ 'a' => true }
].each_with_index do |value, index|
json_value = JSON.generate(value, quirks_mode: true)
json_value = JSON.generate(value)

define_method("test_json_value_#{index}") do
assert_output value, JSON.parse(json_value, quirks_mode: true)
assert_output value, JSON.parse(json_value)
end

define_method("test_exec_value_#{index}") do
Expand Down
Loading