Repository navigation
Support json 3 - #16
Merged
Merged
Conversation
json 3.x no longer accepts the quirks_mode keyword, and json 2.x already handles top-level scalars without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
json 3.x removed the create_additions keyword, and the resulting ArgumentError was retried forever by JSRuntimeHandle#evaluate, hanging CI. JSON.parse never creates additions by default, so the option is redundant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The runtime requires json to decode responses from the Node.js process. It works with json 2.x and 3.x. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json 3.x で動くようにする。
JSON.parseからcreate_additions: falseを外すJSRuntimeHandle#evaluateがそれをリトライし続けるため、JS の評価がハングするJSON.parseは既定で additions を作らないので、json 2.x での挙動は変わらないJSON.generate/JSON.parseからquirks_mode: trueを外すjson >= 2.0の依存を書く🤖 Generated with Claude Code