Repository navigation
feat: isolate widget updates behind an opt-in setting - #333
Merged
daniil-filippov-dev merged 47 commits intoNov 3, 2026
Merged
daniil-filippov-dev merged 47 commits into
daniil-filippov-dev merged 47 commits into
Conversation
Contributor
|
Preview is ready. |
This was referenced Oct 27, 2026
daniil-filippov-dev
marked this pull request as ready for review
October 27, 2026 11:12
daniil-filippov-dev
requested review from
Marginy605,
mournfulCoroner and
roberthovsepyan
as code owners
October 27, 2026 11:12
React GridItem can read stale dragging state when WebKit delivers the next delta before the previous position commits. Wait for the first visible 5px move while retaining exact final geometry, saved layout and event assertions.
korvin89
reviewed
Oct 29, 2026
korvin89
left a comment
korvin89
left a comment
Collaborator
There was a problem hiding this comment.
🤖 AI generated
This review was done with AI assistance. I validated every comment myself, but the wording — including the points I found myself — was written by the AI.
Severity legend
- 🔴 blocker — should be fixed before merge.
- 🟠 should-fix — a real problem; worth fixing before or right after merge. If you can't get to it now, please open an issue and leave a comment linking it.
- 🔵 nit — minor; author's discretion.
- ❓ question — I need more context; not necessarily a defect.
korvin89
previously approved these changes
Oct 30, 2026
React GridItem can read stale dragging state when WebKit delivers the next delta before the previous position commits. Wait for the first visible 5px move while retaining exact final geometry, saved layout and event assertions.
daniil-filippov-dev
dismissed
korvin89’s stale review
October 30, 2026 15:35
The merge-base changed after approval.
daniil-filippov-dev
enabled stacked auto-merge
November 3, 2026 13:20
Base automatically changed from
daniil-filippov-dev/UXRFC-664-common-contracts
to
main
November 3, 2026 13:20
stacked auto-merge was automatically disabled
November 3, 2026 13:20
Replaced by a newer auto-merge request
daniil-filippov-dev
enabled stacked auto-merge
November 3, 2026 13:20
roberthovsepyan
approved these changes
Nov 3, 2026
stacked auto-merge was automatically disabled
November 3, 2026 15:54
Auto-merge was disabled for another pull request in the stack
daniil-filippov-dev
deleted the
daniil-filippov-dev/UXRFC-664-widget-update-isolation
branch
November 3, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI TLDR
Allow callers to isolate widget updates without changing the default full-layout update behavior.
🤖 AI-generated
Merge order: #328 → #331 → #333 → #334 → #335 → #329 → #337. Depends on #331; merge its dependency first.
Add opt-in
isolateItemUpdatesso changing one widget need not rerender unrelated widgets. The default still propagates the full layout, and the opted-in path keeps the widget’s own metadata, data, callbacks, context and registration updates live.An opted-in plugin that reads sibling geometry from the full
layoutcan observe stale sibling geometry; leave isolation disabled for that usage.Validation at published head
a05fedd54bd09fdf42da9e0dc726f02d0d689341against based8476acb67ff904c5869c103f6e2514cc280ed8c: the reviewed normal two-parent ancestry merge preserves the original PR333 tree50e3a644de61c368e7e4b8f8bffff399cdf4b362. Maker verification on this exact tree with Node 22.22.0 passed 75 existing tests, source/browser types, and JS/style/format lint with 76 existing ESLint warnings. Fresh independent bounded AI review accepted the exact ancestry composition; no fresh whole-PR review or human approval is claimed. No additional local browser or build run was made for this ancestry-only merge.Exact-head GitHub checks observed at 2026-10-30T15:47:46.957480+00:00 all completed successfully: Verify Files, Tests (React 19), validate-package, Browser Contracts, Build. React 18 was skipped by the existing release-only workflow guard and was not executed. All three workflow runs completed successfully on attempt 1; no CI retry was requested. GitHub reports no merge conflicts (
MERGEABLE), withBLOCKEDmerge state andREVIEW_REQUIRED; repository review gates and dependency merge order remain required. No merge or release is claimed.Historical validation at head
5029b5df44b6d0db01acb3a33521a38287046618with Node 22.22.0: 5 relevant mounted Jest tests, 6 browser cases across Chromium, Firefox and WebKit, source/browser types, scoped ESLint/formatting and normal build passed. The settled drag helper now waits for exact final live geometry before release. Independent bounded AI review accepted the exact patches; no fresh whole-PR review or human approval is claimed. Existing exact saved-coordinate, immediate-release and outside-release assertions remain. Synthetic native-event probes establish a possible stale-state mechanism; they do not prove the old CI schedule or fix/exclude rapid-input product risk.Historical base:
85e4c220d7495e5a0ef4f2a47654f533a46b9fe8. Exact-head GitHub checks observed at 2026-10-29T21:55:51.425303+00:00 all completed successfully: Build, validate-package, Tests (React 19), Verify Files, Browser Contracts. React 18 was skipped by the existing release-only workflow guard and was not executed. GitHub mergeability isblockedand review decision isREVIEW_REQUIREDat this snapshot. Repository review gates and dependency merge order remain required; no merge or release is claimed.