Repository navigation
test: cover shared DashKit layout contracts - #331
Open
daniil-filippov-dev wants to merge 9 commits into
Open
daniil-filippov-dev wants to merge 9 commits into
daniil-filippov-dev wants to merge 9 commits into
Conversation
Contributor
|
Preview is ready. |
daniil-filippov-dev
marked this pull request as ready for review
October 26, 2026 14:12
daniil-filippov-dev
requested review from
Marginy605,
mournfulCoroner and
roberthovsepyan
as code owners
October 26, 2026 14:12
daniil-filippov-dev
marked this pull request as draft
October 27, 2026 07:18
This was referenced Oct 27, 2026
daniil-filippov-dev
marked this pull request as ready for review
October 27, 2026 13:23
roberthovsepyan
previously approved these changes
Oct 28, 2026
korvin89
reviewed
Oct 28, 2026
korvin89
left a comment
korvin89
left a comment
Collaborator
There was a problem hiding this comment.
🤖 AI generated
This review was done with AI assistance. I validated every comment myself, but the wording — including the points I found myself — was written by the AI.
Severity legend
- 🔴 blocker — should be fixed before merge.
- 🟠 should-fix — a real problem; worth fixing before or right after merge. If you can't get to it now, please open an issue and leave a comment linking it.
- 🔵 nit — minor; author's discretion.
- ❓ question — I need more context; not necessarily a defect.
korvin89
previously approved these changes
Oct 28, 2026
Base automatically changed from
daniil-filippov-dev/UXRFC-664-gridstack-preparation
to
main
October 30, 2026 13:54
React GridItem can read stale dragging state when WebKit delivers the next delta before the previous position commits. Wait for the first visible 5px move while retaining exact final geometry, saved layout and event assertions.
daniil-filippov-dev
force-pushed
the
daniil-filippov-dev/UXRFC-664-common-contracts
branch
from
October 30, 2026 13:54
85e4c22 to
d8476ac
Compare
daniil-filippov-dev
enabled stacked auto-merge
October 30, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI TLDR
Add reusable mounted and browser layout contracts before introducing another renderer.
🤖 AI-generated
Merge order: #328 → #331 → #333 → #334 → #335 → #329 → #337. Depends on #328; merge its dependency first.
Extend the common mounted suite with selector queues, aliases, ignores, namespaces, tabs, group context, overlays, controlled updates, identity and readiness. Test-only Storybook/browser cases exercise real drag/restore, resize, the next move and visible autoheight. Resize checks assert the actual 205×145 widget bounds; CI retains browser failure artifacts for seven days. Public stories exclude test fixtures.
Validation at published head
85e4c220d7495e5a0ef4f2a47654f533a46b9fe8with Node 22.22.0: 5 relevant mounted Jest tests, 6 browser cases across Chromium, Firefox and WebKit, source/browser types, scoped ESLint/formatting and normal build passed. The settled drag helper now waits for exact final live geometry before release. Independent bounded AI review accepted the exact patches; no fresh whole-PR review or human approval is claimed. Existing exact saved-coordinate, immediate-release and outside-release assertions remain. Synthetic native-event probes establish a possible stale-state mechanism; they do not prove the old CI schedule or fix/exclude rapid-input product risk.Current base:
efab67234495c3dcf64f6001a88531720942df45. Exact-head GitHub checks observed at 2026-10-29T21:55:51.425303+00:00 all completed successfully: Tests (React 19), Build, Browser Contracts, Verify Files. React 18 was skipped by the existing release-only workflow guard and was not executed. validate-package did not run because this PR does not change README.md and that workflow is path-filtered. GitHub mergeability isblockedand review decision isREVIEW_REQUIREDat this snapshot. Repository review gates and dependency merge order remain required; no merge or release is claimed.