Repository navigation
examples: close the full_code snippet region with an end marker - #2450
Merged
joefernandez merged 3 commits intoOct 23, 2026
Merged
Conversation
The region opened on line 3 is never closed - line 164 repeats [start:], so pymdownx.snippets runs the include to end-of-file. The rendered output is identical today only because the marker sits after the last line of code, so anything appended to this file would silently be pulled into the published code block. Every other example file closes its regions with [end:].
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joefernandez
approved these changes
Oct 23, 2026
joefernandez
enabled auto-merge (squash)
October 23, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LongRunningFunctionExample.javaopens itsfull_coderegion on line 3 butnever closes it — line 164 repeats a
startmarker instead of ending withend:The region is consumed by
docs/tools-custom/function-tools.md:806.The published output is correct by accident: the stray marker is the last
line of the file, so
pymdownx.snippetsruns an unterminated region toend-of-file and the marker line itself is excluded. Anything appended below it
would silently be pulled into the published code block.
Fix
[start:full_code]->[end:full_code]on line 164.Verification
examples/reports exactly two problems — a duplicatestartand astartwith noend, both on this line — and 0 after the fixproduced by rendering the same
--8<--directive against themaincopy ofthe file and the fixed copy
mkdocs build --stricton the union of this round's five branches:exit 0, 0 warnings