Repository navigation
Conversation
MultiAgentExample.kt defines the region name human_in_loop_pattern twice,
with two start markers and two end markers:
lines 50-70 class ExternalApprovalTool : BaseTool(...) - the tool
lines 353-392 prepareRequest / requestApproval / processDecision ->
SequentialAgent HumanApprovalWorkflow - the workflow
pymdownx.snippets resolves a region at the first matching start marker, so the
second definition is unreachable. docs/workflows/patterns.md:967 is the only
page referencing this region, and it receives the wrong block.
The published "Human in the loop" section is therefore inconsistent across
language tabs - Python, TypeScript and Java all show the workflow composition,
while Kotlin alone shows the tool class with no agents and no workflow.
Rename the first region, the supporting tool class, to human_in_loop_tool so
that human_in_loop_pattern unambiguously resolves to the workflow. The tool
class stays addressable, and patterns.md needs no change.
Verified with a render-based suite (24/24): the pattern region now renders
SequentialAgent + HumanApprovalWorkflow and no longer contains the tool class,
the tool region still renders the class, and every region in the file has
balanced start/end markers.
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MultiAgentExample.ktdefines the region namehuman_in_loop_patterntwice— two
startmarkers and twoendmarkers:class ExternalApprovalTool : BaseTool(…)— the approval toolprepareRequest/requestApproval/processDecision→SequentialAgent HumanApprovalWorkflow— the workflowpymdownx.snippetsresolves a region at the first matchingstartmarker, sothe second definition is unreachable.
docs/workflows/patterns.md:967is theonly page that references this region, and it gets the wrong block.
The effect is a broken "Human in the loop" section. Rendering that page, three
of the four language tabs show the workflow and only Kotlin does not:
LlmAgent,SequentialAgent,FunctionToolLlmAgent,SequentialAgent,FunctionToolLlmAgent,SequentialAgent,approvalWorkflowclass ExternalApprovalTool : BaseTool(— no agents, no workflowConfirmed against the built site: the Kotlin
<pre>block is the tool class,while the neighbouring Java block is the
SequentialAgentcomposition.Fix
Rename the first region — the supporting tool class — to
human_in_loop_tool,so
human_in_loop_patternunambiguously resolves to the workflow. The toolclass remains addressable for anyone who wants it, and
patterns.mdneeds nochange.
Verification
Render-based suite (
verify_batch7.py): 24/24 pass…kt:human_in_loop_patternnow rendersSequentialAgent+HumanApprovalWorkflow, and no longer containsclass ExternalApprovalTool : BaseTool…kt:human_in_loop_toolstill renders the tool classstart/endmarkersA structural scan of all 271 example files covering 612 region markers
finds 3 problems, of which this is one. (One other is already covered by
#2450; the third turned out to be a false positive — pymdownx tolerates a
space inside
[start: …].)mkdocs build --stricton the union of this round's four branches:exit 0, 0 warnings.