Repository navigation
Remove the loop's AGENTS.md from integration - #5
Merged
Merged
Conversation
AGENTS.md held the client-rust-pdca loop's review rubric. It was fork-only: no upstream PR carries it. client-rust-pdca ADR-0015 rule 0 (2026-10-21) allows nothing on integration that is not an upstream pull request, and nothing client-go does not also have. The rubric now lives in client-rust-pdca (docs/rubric/client-rust.md, read through [project.rubric_files]). After this, integration is upstream 1b883bf plus tso-deadline (tikv#558) and test-probes (tikv#577), and nothing else. Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.mdheld the client-rust-pdca loop's review rubric and was fork-only: no upstream PR carries it.client-rust-pdca ADR-0015 rule 0 (getwyrd/client-rust-pdca#16) now says:
integrationholds nothing else;The rubric moves to client-rust-pdca (
docs/rubric/client-rust.md, getwyrd/client-rust-pdca#17).After this,
integrationis upstream1b883bfplustso-deadline(tikv#558) andtest-probes(tikv#577), and nothing else.Merge after getwyrd/client-rust-pdca#17. Until then the loop's client-rust bundles would run with no rubric (it fails open, with a warning).
client-rust has no
AGENTS.mdat all: agent and loop files never go upstream (ADR-0015 rule 0).