Repository navigation
Pin client-rust at 385a1a3 (integration with RawClient::checksum) - #88
Merged
Merged
Conversation
Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
The gate is all green at the new pin and the ledger holds, G-0002 still diverging as declared. ledger-check refuses results produced against a pin pins.toml no longer names, so the candidate-mode fixture is re-recorded from a candidate run at 385a1a3. Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reviewed pin bump per ADR-0001, the step before re-stating G-0002 (#87).
pins.toml:rev=385a1a3, the tip of getwyrd/client-rustintegration;upstream_basestays1b883bf. Since4c9f361: the fork'sAGENTS.mdremoved (Remove the loop's AGENTS.md from integration client-rust#5),RawClient::checksum(Add G-0002: raw checksum, the first capability claim (+ the 3-store cluster profile) #6, G-0002's close-gap), and CI-only changes (Shepherd tikv/client-rust#544 to merge (orphaned-lock resolution, G-0001) #7, Shepherd tikv/client-rust#547 to merge (pessimistic rollback clears prewrite locks) #8, Review & support tikv/client-rust#535 (JoinSet instead of try_join_all) #9).findings/gate-evidence-385a1a3.txt: captured withPARITY_STRICT=1at harness148584aon a leased single-node v8.5.5 cluster. The gate is all green (18 + 1 passed,d6andd7included), and the ledger holds: G-0001 and G-0003 agree, and G-0002 diverges as declared. No claim moved.unsupported, not client-rust. The README,pins.tomland the evidence say so; 5.6 Raw Checksum: re-state G-0002 once the Rust driver calls RawClient::checksum #87 re-states it and fixes the stale texts.ledger-checkrefuses results produced against a pinpins.tomlno longer names. The run's base was set to the pin commit, soledger-checkjudged it (G-0002 XDIVERGE, every other claim holds) instead of refusing it for editingpins.toml.385a1a3, and4c9f361moves to History.make checkpasses locally (96 tests; one broker test skipped while a cluster held the ports). Reviewed by codex twice and by a second agent; the fixes for their findings are in the second commit.The upstream view is unchanged by this bump and runs as CI's
upstream-viewjob here.