Repository navigation
fix(js/ts/python): synchronize cancellation registrations - #5036
Merged
Merged
Conversation
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
dbrattli
marked this pull request as ready for review
October 3, 2026 21:51
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Python cancellation registration returns
None, so callers cannot dispose listeners. Cancellation also iterates a mutable listener dictionary: callbacks can invalidate iteration, failures skip other listeners, and registration can race cancellation. JS retains completed registrations and fails to invoke late registrations. These behaviors differ from .NET and surfaced with published Fable/fable-library 5.19.0.How
Nonestate.boolsubtype ofintcausedFalseandTrueto also schedule cancellation after 0 ms and 1 ms, respectively.Validation