Repository navigation
refactor: use upstream async runtime fixes - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actor-owned lifetimes carry Python lock, cancellation-registration, timer and delayed-continuation workarounds for defects in the older Fable runtime. This change uses the fixes released in Fable 5.20.1 while preserving actor shutdown, request/reply settlement and cleanup behavior.
lock, disposableCancellationToken.Register,Async.Sleepandasync.Delay; remove the corresponding Python platform helpers and cancellation guards.Upstream prerequisites
All required fixes are merged and included in Fable 5.20.1:
Validation
Executed using the released
dotnet fable5.20.1 and PyPIfable-library5.20.1, with no local compiler or runtime overrides:rebar3.just check, Fantomas 8.0.8--check,git diff --checkand NuGet packing passed.Fantomas reports the existing unsupported
.editorconfigsetting; BEAM compilation reports existing unused-result warnings. Neither prevents validation.