Repository navigation
feat(da): sign blob submissions and broadcast over consensus gRPC #3483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damiannolan
wants to merge
13
commits into
main
Choose a base branch
from
damian/signed-blobs-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ea955fe
feat(block): allow injecting a blob submitter into the DA client
damiannolan 95159c6
feat(config): add da.tx_signer section
damiannolan 882f079
fix(config): require da.address for tx_signer, drop network and worke…
damiannolan 903ad96
fix(da): map current celestia submit errors to blob statuses
damiannolan 291ce91
feat(da/celestia): sign PayForBlobs locally with the celestia-app tx …
damiannolan afce813
feat(apps): wire da.tx_signer into testapp and evm
damiannolan ad3d884
test(e2e): cover signed blob submission
damiannolan 4329a5a
docs: document da.tx_signer
damiannolan af5b6d2
fix(da): map celestia-app max tx size errors to StatusTooBig
damiannolan 73142c8
fix(da/celestia): stop the tx client on Close and validate config at …
damiannolan 2f42b28
test(e2e): fail on signer balance query errors
damiannolan f619830
docs(da/celestia): add package overview
damiannolan 3add9c8
docs: fix dead links flagged by the link checker
damiannolan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: evstack/ev-node
Length of output: 1242
🏁 Script executed:
Repository: evstack/ev-node
Length of output: 24703
🏁 Script executed:
Repository: evstack/ev-node
Length of output: 32058
Enable signing for force-inclusion submissions.
The
--force-inclusion-serverflag enables the server without a node-role check. When signing is enabled on a node that is neither an aggregator nor promotable, the signer is not added to the DA client. The server stores that client, andeth_sendRawTransactioncallsdaClient.Submit. Such requests can fail against DA endpoints that require signed submissions.Include force-inclusion servers in the signer condition, or reject this configuration during startup.
🤖 Prompt for AI Agents