Use JFace tree path breadcrumb in Debug UI

debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/breadcrumb/AbstractBreadcrumb.java

@@ -19,6 +19,7 @@
 import org.eclipse.jface.viewers.ISelectionProvider;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.viewers.StructuredSelection;
+import org.eclipse.jface.viewers.TreePathBreadcrumbViewer;
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.layout.GridData;
 import org.eclipse.swt.layout.GridLayout;
@@ -30,7 +31,6 @@
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.swt.widgets.Widget;
 
-
 /**
  * Breadcrumb base class.  It creates the breadcrumb viewer and manages
  * its activation.
@@ -42,7 +42,7 @@
  */
 public abstract class AbstractBreadcrumb {
 
-	private BreadcrumbViewer fBreadcrumbViewer;
+	private TreePathBreadcrumbViewer fBreadcrumbViewer;
 
 	private boolean fHasFocus;
 
@@ -67,7 +67,7 @@
 	 * @param parent the parent composite
 	 * @return the viewer
 	 */
-	protected abstract BreadcrumbViewer createViewer(Composite parent);
+	protected abstract TreePathBreadcrumbViewer createViewer(Composite parent);
 
 	/**
 	 * Open the element in a new editor if possible.
@@ -95,7 +95,7 @@
 	 * @return the selection provider for this breadcrumb
 	 */
 	public ISelectionProvider getSelectionProvider() {
 		return fBreadcrumbViewer;
 	}
 
 	/**
@@ -104,22 +104,22 @@
 	 * @param element the input element can be <code>null</code>
 	 */
 	public void setInput(Object element) {
 		if (element == null || fBreadcrumbViewer == null || fBreadcrumbViewer.getControl().isDisposed()) {
 			return;
 		}
 
 		Object input= fBreadcrumbViewer.getInput();
 		if (input == element || element.equals(input)) {
 			refresh();
 			return;
 		}
 
 		fBreadcrumbViewer.setInput(element);
 	}
 
 	protected void refresh() {
 		if (!fBreadcrumbViewer.getControl().isDisposed()) {
 			fBreadcrumbViewer.refresh();
 		}
 	}
 
@@ -129,10 +129,10 @@
 	 * actions.
 	 */
 	public void activate() {
 		if (fBreadcrumbViewer.getSelection().isEmpty()) {
 			fBreadcrumbViewer.setSelection(new StructuredSelection(fBreadcrumbViewer.getInput()));
 		}
 		fBreadcrumbViewer.setFocus();
 	}
 
 	/**
@@ -188,22 +188,18 @@
 		};
 		Display.getCurrent().addFilter(SWT.FocusIn, fDisplayFocusListener);
 
 		fBreadcrumbViewer= createViewer(fComposite);
 
 		fBreadcrumbViewer.addDoubleClickListener(event -> {
 			Object element= ((IStructuredSelection) event.getSelection()).getFirstElement();
 			if (element == null) {
 				return;
 			}
 
-			BreadcrumbItem item= (BreadcrumbItem) fBreadcrumbViewer.doFindItem(element);
-			if (item == null) {
-				return;
-			}
-			item.openDropDownMenu();
+			fBreadcrumbViewer.openDropDownMenu(element);
 		});
 
 		fBreadcrumbViewer.addOpenListener(event -> doOpen(event.getSelection()));
 
 		return fComposite;
 	}
@@ -226,7 +222,7 @@
 	 */
 	private void doOpen(ISelection selection) {
 		if (open(selection)) {
 			fBreadcrumbViewer.setInput(getCurrentInput());
 		}
 	}
 
@@ -292,7 +288,7 @@
 	 * @return <code>true</code> if event was generated by a breadcrumb child
 	 */
 	private boolean isBreadcrumbEvent(Event event) {
 		if (fBreadcrumbViewer == null) {
 			return false;
 		}
 
@@ -301,12 +297,12 @@
 			return false;
 		}
 
 		Shell dropDownShell= fBreadcrumbViewer.getDropDownShell();
 		if (dropDownShell != null && isChild((Control) item, dropDownShell)) {
 			return true;
 		}
 
 		return isChild((Control) item, fBreadcrumbViewer.getControl());
 	}
 
 	private boolean isChild(Control child, Control parent) {